From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 7 03:30:22 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9B0616A4B3 for ; Tue, 7 Oct 2003 03:30:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35F6743FB1 for ; Tue, 7 Oct 2003 03:30:22 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h97AULFY092073 for ; Tue, 7 Oct 2003 03:30:21 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h97AULPW092070; Tue, 7 Oct 2003 03:30:21 -0700 (PDT) (envelope-from gnats) Date: Tue, 7 Oct 2003 03:30:21 -0700 (PDT) Message-Id: <200310071030.h97AULPW092070@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Philipp Mergenthaler Subject: Re: Re: bin/50365: [PATCH] rc.sysctl cannot handle values containing spaces X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Philipp Mergenthaler List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Oct 2003 10:30:23 -0000 The following reply was made to PR bin/50365; it has been noted by GNATS. From: Philipp Mergenthaler To: freebsd-gnats-submit@FreeBSD.org, christopher.rodgers@st-johns.oxford.ac.uk Cc: Subject: Re: Re: bin/50365: [PATCH] rc.sysctl cannot handle values containing spaces Date: Tue, 7 Oct 2003 12:28:58 +0200 I'd like to see this fixed, too. The original patch doesn't apply on -current anymore (because of the new /etc/rc.d), though. Below is an updated version. Index: etc/rc.d/sysctl =================================================================== RCS file: /ncvs/src/etc/rc.d/sysctl,v retrieving revision 1.12 diff -u -r1.12 sysctl --- etc/rc.d/sysctl 24 Apr 2003 08:20:47 -0000 1.12 +++ etc/rc.d/sysctl 7 Oct 2003 07:47:52 -0000 @@ -46,7 +46,7 @@ ${val}) ;; *) - sysctl ${var} + sysctl "${var}" ;; esac elif [ "$1" = "last" ]; then Index: share/man/man5/sysctl.conf.5 =================================================================== RCS file: /ncvs/src/share/man/man5/sysctl.conf.5,v retrieving revision 1.15 diff -u -r1.15 sysctl.conf.5 --- share/man/man5/sysctl.conf.5 9 Jan 2002 16:09:00 -0000 1.15 +++ share/man/man5/sysctl.conf.5 7 Oct 2003 07:34:07 -0000 @@ -43,6 +43,8 @@ sysctl_mib=value .Ed .Pp +Spaces must be escaped with a backslash. +Do not enclose the value in quotation marks. Comments are denoted by a .Dq # at the beginning of a line. Comments can also exist at the end of a line,