From owner-freebsd-bugs@FreeBSD.ORG  Mon Nov  1 21:10:31 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 21C7B16A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  1 Nov 2004 21:10:31 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 11CB243D31
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  1 Nov 2004 21:10:31 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iA1LAUcw070156
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 1 Nov 2004 21:10:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA1LAUSC070155;
	Mon, 1 Nov 2004 21:10:30 GMT
	(envelope-from gnats)
Date: Mon, 1 Nov 2004 21:10:30 GMT
Message-Id: <200411012110.iA1LAUSC070155@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Keith Winter" <keith@sentex.net>
Subject: Re: kern/72935: sio tty and uhid tty (perhaps others) stomp on each
	other leading to kernel data corruption and a panic
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Keith Winter <keith@sentex.net>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Nov 2004 21:10:31 -0000

The following reply was made to PR kern/72935; it has been noted by GNATS.

From: "Keith Winter" <keith@sentex.net>
To: <freebsd-gnats-submit@FreeBSD.org>, <freebsd-dev@sentex.net>
Cc: <freebsd-usb@FreeBSD.org>
Subject: Re: kern/72935: sio tty and uhid tty (perhaps others) stomp on each other leading to kernel data corruption and a panic
Date: Mon, 1 Nov 2004 16:04:59 -0500

 We are trying to generalize the fix for this.  It was pointed out by Julian Elischer that this prevents bio devices from trampling
 on tty devices, but not vice versa.
 
 Would the following be a more general solution for uhid devices?
 
         {
                 int s = splhigh();
                 tty_imask |= bio_imask;
                 bio_imask |= tty_imask;
                 update_intr_masks();
                 splx( s );
         }
 
 The approach is similar to what was done for ppp/slip.
 
 -- KDW