From owner-freebsd-ports@FreeBSD.ORG Wed Jun 16 09:38:42 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 364061065673 for ; Wed, 16 Jun 2010 09:38:42 +0000 (UTC) (envelope-from ade@FreeBSD.org) Received: from panix.lovett.com (panix.lovett.com [166.84.7.128]) by mx1.freebsd.org (Postfix) with ESMTP id 114F08FC13 for ; Wed, 16 Jun 2010 09:38:41 +0000 (UTC) Received: from [96.39.161.134] (helo=[172.16.32.106]) by panix.lovett.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1OOqKX-0002iV-83; Wed, 16 Jun 2010 10:58:49 +0000 Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Ade Lovett In-Reply-To: <20100616010957.85686.qmail@exxodus.fedaykin.here> Date: Wed, 16 Jun 2010 02:38:29 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <372D79A4-91FB-43F2-9B43-A8FCC80FC004@FreeBSD.org> References: <20100616010957.85686.qmail@exxodus.fedaykin.here> To: Mario Sergio Fujikawa Ferreira X-Mailer: Apple Mail (2.1078) Cc: freebsd-ports@FreeBSD.org Subject: Re: RFC: Mk/bsd.jpeg.mk to automagically handle jpeg dependency X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2010 09:38:42 -0000 On Jun 15, 2010, at 18:09 , Mario Sergio Fujikawa Ferreira wrote: > Hi, >=20 > Ever since the addition of graphics/libjpeg-turbo, I had > been wondering how one could possibly build the whole ports tree > with it instead of graphics/jpeg. I wanted the choice. >=20 > Therefore, I wrote the attached bsd.jpeg.mk as a suggestion. I have other concerns, but the fundamental one is bsd.jpeg.mk is way too = specific, and could easily lead to bsd.tiff.mk, bsd.gd.mk, etc.. etc.. You might want to consider abstracting it out a little further (compare = with bsd.database.mk) to, say, bsd.graphics.mk It might then be possible to do weird and wonderful things like: USE_GRAPHICS=3D jpeg-turbo openexr gd tiff in ports Makefiles, and have them do the right thing, or at least offer = up include and library paths, along with relevant *_DEPENDS additions. It's a little more work in the short term, but there's plenty of = existing Mk/* files to use as reference for parsing a possible = USE_GRAPHICS stanza, and it is much more extensible. -aDe