From owner-svn-src-all@freebsd.org  Sat Aug 29 08:56:49 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3F9B03D221C;
 Sat, 29 Aug 2020 08:56:49 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Bdr1X67G9z48tn;
 Sat, 29 Aug 2020 08:56:48 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [178.17.145.105])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 5F54D26024C;
 Sat, 29 Aug 2020 10:56:41 +0200 (CEST)
Subject: Re: svn commit: r364944 - head/sys/kern
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <202008290429.07T4TrbH007764@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <25be5af1-76a9-78a1-4e4f-2777b0e7f350@selasky.org>
Date: Sat, 29 Aug 2020 10:56:12 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <202008290429.07T4TrbH007764@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4Bdr1X67G9z48tn
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Aug 2020 08:56:49 -0000

On 2020-08-29 06:29, Warner Losh wrote:
> +#define DEVCTL_BUFFER (1024 - sizeof(void *))
>   struct dev_event_info {
> -	char *dei_data;
>   	STAILQ_ENTRY(dev_event_info) dei_link;
> +	char dei_data[DEVCTL_BUFFER];
>   };

Maybe add:

CTASSERT(sizeof(struct dev_event_info) == 1024);

Not sure if STAILQ's can have some debug fields in them.

--HPS