Date: Sat, 19 Jan 2019 23:15:59 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r490569 - in head/graphics: mesa-dri mesa-dri/files mesa-libs Message-ID: <20190119221559.nkky4mnz7jxqfdjy@atuin.in.mat.cc> In-Reply-To: <imyk-u4o2-wny@FreeBSD.org> References: <201901171534.x0HFYbZ8087462@repo.freebsd.org> <20190119102012.olepcljgxtstrz7i@atuin.in.mat.cc> <imyk-u4o2-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--lzlnk2nfrtwwdggv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 19, 2019 at 03:02:05PM +0100, Jan Beich wrote: > Mathieu Arnold <mat@FreeBSD.org> writes: >=20 > > On Thu, Jan 17, 2019 at 03:34:37PM +0000, Jan Beich wrote: > > > >> Approved by: maintainer timeout (2 weeks after 2019Q1) > > > > portmgr hat on. > > > > Maintainer timeout means the maintainer never said anything. In this > > case, the maintainers clearly told you NO repeatedly, see comments 3, 5, > > 9, and also by the maintainer setting explicitely > > "maintainer-feedback-". >=20 > In bug 233034 comment 1 said there was a dicision to wait for 2019Q1. > I've asked how to interpret this in comment 2, and comment 3 elaborated. > I've pinged the team in comment 6 but got no response for 2 weeks. Given > the silence, the decision to land in 2019Q1 and positive call for testing > I've landed the patch, assuming responsibility for any regressions. >=20 > Bug 230298 was obsoleted by bug 233034. I guess, landing it separately > led to a confusion. Even there the maintainer's feedback wasn't as > simple as NO: the alleged regressions turned out to be known issues, > wait until after EuroBSDCon became obsolete, maintainer-feedback- > was a misuse of the flag, lack of testing was covered by call for testing, > testing protocol never materialized, that bug was the place where the > coordination happened, etc. >=20 > Before opening the can of worms I wish you've waited for maintainer's > response if I did anything wrong when applying the timeout. Funny you'd say that, I only opened that can of worms because the maintainers complained that it was not the first time you committed stuff to the graphics stack without waiting for maintainer approval. So, let me repeat. Do not, ever again, commit to a port maintained by x11@ without their explicit approval, and I mean, someone saying, in a PR "ok, please commit". > > When the maintainer says NO, it does not mean you have to wait 2 weeks > > to update the port, it means you absolutely will not, ever, commit the > > patch. >=20 > In that case, can you document maintainers can stall patches however long > they want and "not exclusive ownership" is actually false? >=20 > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer= =2Ehtml The maintainer said "NO", three times to you in that PR. Yes, a maintainer can delay, or refuse your patches. If that is not clear enough, I am not sure what could be. --=20 Mathieu Arnold --lzlnk2nfrtwwdggv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxDoZ9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgTWxAAisHcNx1YbPvpea6sItcWRTf41HPjlB5D1pHStdGvaso9LMqizcbk+1t9 JDRxf07szznJc08UI2gTUnWbVgvZaWIFzmDMr4RcRjTu3vlM46uNM97PnFIpt+D5 ynkRtY7oyxwKF0a3TLbkqK6A4QIm0jDqSciQNpdWr8Cf77eutvl+gG3Q8vIg04PA tDuhaK9rzXyCGYNmqrL35e/ZInF2sDOWC3Pla507JO923iaI2qMeggpf3hyC9x5P 5lwJAC9hyDkif2/WqUFxmJykpxxtabNvSqvBM/XZ0sdcWdDsZTqWNHqeJMszxqQm z+tAPHjZeMLLUz/DMBEPxDuwpRP/osyP8EgRG3FLGIw8QAfRTGFQGcc0BXNXBpTs w+NhOTK3EA4IE8RbLCLu8j//EQr8Iu4wjiNnLf1p+NMKHx9sSPuY1P1rYs5LkKUa Mk8DELGWelKTawYJWakEUBjgodY2wnXREneQeZNtGTv2Kp4va8clBfp+jKp+W+Ty gbOtWICKIEs/+hczqzUN7NDcecl/JL7NJg4UpnS+DnzWwOj1a/+Z0mRqIOo/W5Fm bT9y7FojHbG0dQPyS8kUPXSPMSpswZMuE6TYRs+ajGvj2vCertZ3QRIioGJ4zJGX bCEVKIwYwxdaN2CsPfeeT1t59gOw2eeYIlQt1Xu7MZmNNYQB51A= =AMHw -----END PGP SIGNATURE----- --lzlnk2nfrtwwdggv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190119221559.nkky4mnz7jxqfdjy>