From nobody Mon Oct 28 23:12:10 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xcq0W3xD8z5btcY; Mon, 28 Oct 2024 23:12:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xcq0W10s3z58fZ; Mon, 28 Oct 2024 23:12:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730157131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SAaTvvka2tFPUsCSuArnDVw3PCEuadL8rLCHkphEVpU=; b=v8TYyfXVyTdVzWEcVlijRplgiFYfMkDXI2+GD4kaG3kZFYmwWwnJeJI6b/DLGYd6MYYvzc H78szpQjZ6rLnkw3YNv0V5nWfcLPaOGfoqZLrd4yi/6L+qYgTOoWk9644Vhp1yuwKG+/1c cymKsd6nFn9ZPq8axN/nExVI0NEXhZuJo2JWb/iHVYV0vXwMWaE1diQrD/13+C53cySwle f17cTgjCO3L47HSpZFQaHIew03VxXM5peDbOMOMis6DZbm8N0n5fKrn/j8uJNck7Q2Kmk4 QsAJAEeJ+yB+m8DHzCbd6gT+CjF2Fem8wv6aGspZ2FtP8GqeIEhzfG2iBYT53Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730157131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SAaTvvka2tFPUsCSuArnDVw3PCEuadL8rLCHkphEVpU=; b=OPGfj1cU3XTvkLPPg4q8hvniUz7hNiwnIKynVwuqFdMdL9tCEMUrxox3+xB9W0WYptOEMQ BNAIE2wKUFnJO7umcik/UviKIqqW8ZjCVT7rSMBbBt8areBDvE6SLtYeOMkmdNrDp3xLf1 17L5ILew3liVKGyVerZNCl5VO7Ugh3353QcjsJMQ4yB91/MyAkrFJQLcqiisQbaROCdYY+ mwEKAZU7aMUi57kx77LZ8D7Tt6t2HbvEmIQk+D8buqaetLLwLzC2Oc/atAaW98hR13U7wT A/mlXMKjGAmIqTxTN5u/LZjZ3iadDh9HUylyK+cnB/MK7DeIBht8xgSgqbcAqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730157131; a=rsa-sha256; cv=none; b=dccsWhzqCfTk0j06YM0EWvD3/BwlatX9VSfdVfVAb3+oD08N8m7ZbuULi6Djq93F3LH6xD 5CPK8MoiVfJhkNcZEk5E1cZE1Qg9UP8nhJKEKzTkn7eUpTEYZARYM2TOJVOyL9Cn/pkfJ+ zChH2AvUmKKTHKCaPecMx7gdFsqTwRsM4UpDKOUTMUHXjwj/QyB0M1PLNeFtoHPHQXvgS+ gTAYD4DPQHayVd6XYmNdVSp8kA+JFhxgNck2pG6oPqWgf3sB3dKISMCWNLIydqnFQznxSw 9Yx5bbItkves2pXCyEaa/Tk6DMb9hF4xeCbDDOhHbKxIWJBECfMurCutU8a9vA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xcq0W0d9qzywM; Mon, 28 Oct 2024 23:12:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49SNCAvL039887; Mon, 28 Oct 2024 23:12:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49SNCA2J039883; Mon, 28 Oct 2024 23:12:10 GMT (envelope-from git) Date: Mon, 28 Oct 2024 23:12:10 GMT Message-Id: <202410282312.49SNCA2J039883@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: f2daf89954a4 - main - cxgb(4): Register ifmedia callbacks before ether_ifattach. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f2daf89954a45c7eed22990dd4cf2cf879763dc0 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=f2daf89954a45c7eed22990dd4cf2cf879763dc0 commit f2daf89954a45c7eed22990dd4cf2cf879763dc0 Author: ScottD AuthorDate: 2024-10-28 20:48:16 +0000 Commit: Navdeep Parhar CommitDate: 2024-10-28 23:10:05 +0000 cxgb(4): Register ifmedia callbacks before ether_ifattach. This prevents a panic that occurs if netlink tries to invoke the driver's media callbacks during ifattach. PR: 282374 Reported by: ScottD MFC after: 3 days --- sys/dev/cxgb/cxgb_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/cxgb/cxgb_main.c b/sys/dev/cxgb/cxgb_main.c index 4d754aa8b1b7..c159849076c5 100644 --- a/sys/dev/cxgb/cxgb_main.c +++ b/sys/dev/cxgb/cxgb_main.c @@ -1041,6 +1041,11 @@ cxgb_port_attach(device_t dev) if_sethwassistbits(ifp, 0, CSUM_TSO); } + /* Create a list of media supported by this port */ + ifmedia_init(&p->media, IFM_IMASK, cxgb_media_change, + cxgb_media_status); + cxgb_build_medialist(p); + ether_ifattach(ifp, p->hw_addr); /* Attach driver debugnet methods. */ @@ -1055,11 +1060,6 @@ cxgb_port_attach(device_t dev) return (err); } - /* Create a list of media supported by this port */ - ifmedia_init(&p->media, IFM_IMASK, cxgb_media_change, - cxgb_media_status); - cxgb_build_medialist(p); - t3_sge_init_port(p); return (err);