Date: Tue, 02 Oct 2012 14:44:04 -0700 From: Xin Li <delphij@delphij.net> To: Eitan Adler <lists@eitanadler.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, "freebsd-security@freebsd.org" <freebsd-security@freebsd.org>, Erik Cederstrand <erik@cederstrand.dk> Subject: Re: Opinion on checking return value of setuid(getuid())? Message-ID: <506B6024.8050908@delphij.net> In-Reply-To: <CAF6rxgnkLcoL4eAbKxC=-OY=G9O--TLYT8C2xEtu1u7yrNUD5A@mail.gmail.com> References: <9DD86238-51C8-4F38-B7EB-BD773039888B@cederstrand.dk> <20121001104901.GJ35915@deviant.kiev.zoral.com.ua> <F81C009D-F993-4398-B377-D0B4A0ABA7E3@cederstrand.dk> <20121001110805.GL35915@deviant.kiev.zoral.com.ua> <CAF6rxgmKWfefr5tvM3-0PQM3EKWockkb8A4sCiyYekxs5b4fGA@mail.gmail.com> <ECC8690A-9B5D-41FB-BF1D-CC170147BEEC@cederstrand.dk> <CAF6rxgnkLcoL4eAbKxC=-OY=G9O--TLYT8C2xEtu1u7yrNUD5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/02/12 07:45, Eitan Adler wrote: > On 2 October 2012 08:38, Erik Cederstrand <erik@cederstrand.dk> > wrote: >> Den 01/10/2012 kl. 13.55 skrev Eitan Adler >> <lists@eitanadler.com>: >> >>> On 1 October 2012 07:08, Konstantin Belousov >>> <kostikbel@gmail.com> wrote: >>>> I do not believe in the dreadful 'flood ping' security >>>> breach. Is a local escalation possible with non-dropped root >>>> ? >>> >>> It is clearly a local escalation: a non-root user can do >>> something which was intended only for root. It is a different >>> question how serious the breach is. >> >> Are there any objections to the path I attached in my first post? >> To the approach in general? If not, I'll send a PR so it doesn't >> get lost. > Not by me. Please cc me on the PR as I'll commit if no one else > objects. It doesn't seem hurt in general but if you are going to commit it please also change the other instances in the base system. I personally don't think this is useful either -- the case does not apply to FreeBSD and it seems that the Linux implementation is actually a POSIX violation as setuid() is not permitted to return ENOMEM. Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQa2AkAAoJEG80Jeu8UPuzgYEIAJ3C6ktqB/Pbc7oMiKv0+WJQ NJ5RHWqXp98mDDWrkVhwiCoYjACgvnrRmHujk4Rc/uo5+fVNAGGsagvuBn04ZXOk ANDG+dpsYN1uuQQtabheoO/EoZRVd+0q84mM9gNC6qcHPzXgqJLc+pRQpfG2tTxk wqYqG4d4FTSGveOiGqJV8jvvAyLIxhEXvaoLNEPYyKKC7tKVEOZDH355Zi0C0KIh otZrlKna7WECSd3vCZArnd/qTO+s9WorgUGXPJdN57a1r4QIZM1/Hrja5R2wMtvU dLeo+MVnDjmP6Lpp22dQFg/sj3LQnnVTTC/uZSYanfqf6f6xFjm8hp+EkhJJdjA= =12ki -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506B6024.8050908>