From owner-freebsd-fs@FreeBSD.ORG  Wed May 29 00:40:01 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 6B0DB83D
 for <freebsd-fs@smarthost.ysv.freebsd.org>;
 Wed, 29 May 2013 00:40:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 43D10871
 for <freebsd-fs@smarthost.ysv.freebsd.org>;
 Wed, 29 May 2013 00:40:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4T0e1O4079617
 for <freebsd-fs@freefall.freebsd.org>; Wed, 29 May 2013 00:40:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4T0e0du079616;
 Wed, 29 May 2013 00:40:00 GMT (envelope-from gnats)
Date: Wed, 29 May 2013 00:40:00 GMT
Message-Id: <201305290040.r4T0e0du079616@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/177335: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2013 00:40:01 -0000

The following reply was made to PR kern/177335; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177335: commit references a PR
Date: Wed, 29 May 2013 00:32:57 +0000 (UTC)

 Author: rmacklem
 Date: Wed May 29 00:32:49 2013
 New Revision: 251089
 URL: http://svnweb.freebsd.org/changeset/base/251089
 
 Log:
   Add a patch analygous to r248567, r248581, r251079 to the
   old NFS client to avoid the panic reported in the PR by
   doing the vnode_pager_setsize() call after unlocking the mutex.
   
   PR:		177335
   MFC after:	2 weeks
 
 Modified:
   head/sys/nfsclient/nfs_subs.c
 
 Modified: head/sys/nfsclient/nfs_subs.c
 ==============================================================================
 --- head/sys/nfsclient/nfs_subs.c	Wed May 29 00:19:58 2013	(r251088)
 +++ head/sys/nfsclient/nfs_subs.c	Wed May 29 00:32:49 2013	(r251089)
 @@ -463,6 +463,8 @@ nfs_loadattrcache(struct vnode **vpp, st
  	struct timespec mtime, mtime_save;
  	int v3 = NFS_ISV3(vp);
  	int error = 0;
 +	u_quad_t nsize;
 +	int setnsize;
  
  	md = *mdp;
  	t1 = (mtod(md, caddr_t) + md->m_len) - *dposp;
 @@ -565,6 +567,8 @@ nfs_loadattrcache(struct vnode **vpp, st
  		vap->va_filerev = 0;
  	}
  	np->n_attrstamp = time_second;
 +	setnsize = 0;
 +	nsize = 0;
  	if (vap->va_size != np->n_size) {
  		if (vap->va_type == VREG) {
  			if (dontshrink && vap->va_size < np->n_size) {
 @@ -591,7 +595,8 @@ nfs_loadattrcache(struct vnode **vpp, st
  				np->n_size = vap->va_size;
  				np->n_flag |= NSIZECHANGED;
  			}
 -			vnode_pager_setsize(vp, np->n_size);
 +			setnsize = 1;
 +			nsize = vap->va_size;
  		} else {
  			np->n_size = vap->va_size;
  		}
 @@ -628,6 +633,8 @@ nfs_loadattrcache(struct vnode **vpp, st
  		KDTRACE_NFS_ATTRCACHE_LOAD_DONE(vp, &np->n_vattr, 0);
  #endif
  	mtx_unlock(&np->n_mtx);
 +	if (setnsize)
 +		vnode_pager_setsize(vp, nsize);
  out:
  #ifdef KDTRACE_HOOKS
  	if (error)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"