From owner-freebsd-x11@FreeBSD.ORG  Mon Mar  8 09:45:59 2010
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: x11@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EC7D1106566B
	for <x11@FreeBSD.org>; Mon,  8 Mar 2010 09:45:59 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])
	by mx1.freebsd.org (Postfix) with ESMTP id ABAF68FC1B
	for <x11@FreeBSD.org>; Mon,  8 Mar 2010 09:45:59 +0000 (UTC)
Received: from acrux.dbai.tuwien.ac.at (acrux.dbai.tuwien.ac.at
	[128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id 613831E05B
	for <x11@FreeBSD.org>; Mon,  8 Mar 2010 10:45:58 +0100 (CET)
Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203)
	id 5DEDE1604A; Mon,  8 Mar 2010 10:45:59 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id 4D5DF16048
	for <x11@FreeBSD.org>; Mon,  8 Mar 2010 10:45:59 +0100 (CET)
Date: Mon, 8 Mar 2010 10:45:59 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: x11@FreeBSD.org
In-Reply-To: <alpine.LSU.1.99.1002150050340.21091@acrux.dbai.tuwien.ac.at>
Message-ID: <alpine.LSU.1.99.1003081044370.385@acrux.dbai.tuwien.ac.at>
References: <alpine.LSU.1.99.1002150050340.21091@acrux.dbai.tuwien.ac.at>
User-Agent: Alpine 1.99 (LSU 1142 2008-08-13)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: 
Subject: Re: PATCH: x11/libXdmcp needs USE_GNOME=pkgconfig
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Mar 2010 09:46:00 -0000

Ping.  Here are some relevant lines from building this port:

  checking for pkg-config... /usr/local/bin/pkg-config
  checking pkg-config is at least version 0.9.0... yes

Okay to commit?

Gerald @FreeBSD.org

On Mon, 15 Feb 2010, Gerald Pfeifer wrote:
> I noticed that x11/libXdmcp uses pkg-config, but fails to set
>   USE_GNOME=     pkgconfig
> in its Makefile.
> 
> Unless this is intentional and I am missing something, do you
> approve of the patch below?
> 
> Gerald @FreeBSD.org
> 
> 
> Index: libXdmcp/Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/x11/libXdmcp/Makefile,v
> retrieving revision 1.15
> diff -u -r1.15 Makefile
> --- libXdmcp/Makefile	13 Mar 2008 10:33:54 -0000	1.15
> +++ libXdmcp/Makefile	14 Feb 2010 23:51:00 -0000
> @@ -15,5 +15,6 @@
>  
>  XORG_CAT=	lib
>  USE_XORG=	xproto:both
> +USE_GNOME=	pkgconfig
>  
>  .include <bsd.port.mk>