From owner-freebsd-ports@freebsd.org Fri Jun 9 11:55:56 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7802BF2B8A for ; Fri, 9 Jun 2017 11:55:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x22c.google.com (mail-pf0-x22c.google.com [IPv6:2607:f8b0:400e:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 928606468D for ; Fri, 9 Jun 2017 11:55:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x22c.google.com with SMTP id x63so27822237pff.3 for ; Fri, 09 Jun 2017 04:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0j8Xsc/s88pKrmGPjZUWPwRdwSv0ZFsb7TZZRlozkq8=; b=spCu/nJuQPQDgjDMV9kiADN2hzXDzbAb5tSnupVGs+DUfBP1pv/zourS4S5uPbBNJw G2PqBYlLDyKUF0ZumQF9ntXZuwl+S10RfsY0d7rWlGkLFjxsv60wC5L8j3DwbuexSDkp 6N+vHAIh5SJK+lZrpWnNpA6TEkMoaq0rVJjiU9M+zAZ8v60LWsEijHtAyEzTL5W39n05 X5ulCmQXPXtLIW9o5jpGhrT2ZmrrNR2YyVAIjCe3YeyK+JdOsSDN6aI8aizVNoBKl1dY m8SMqHGx39tUpbcFmkHdFhcHWxkyjwjjkr83uHp2Rz1tZDqycJzhVK8omdR2LYEdXx5i Srqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0j8Xsc/s88pKrmGPjZUWPwRdwSv0ZFsb7TZZRlozkq8=; b=TL25IZX/CPvyjxAz5gkUBFwbwa5lDV5i/3XMST7n1nqSZ21rvWa6EJXSrhFTTKXyXG N5okiym3kJWjJ+g8g2vArUN/sXGpgDcGp6xUgLgQRo9qbw/+sO0oHslqzFTyoFcRSuQ1 souOg6PkunJUG7uu4zHjdSufDmEqTOULgWTF0sLnuOXkAFgesTmbGjEk0+y3xpdFGPVn itfZGyvIlK2H/HNb+WKwVYOEHeZcxmT6kKYfKFsgTRyENWZiNAPO0IvyrkeRq9zXQ3yv LeLBkfZVkxXERPJp9UN718K13nuXQzTzNqjE7OATvU5F7Cpf/zeL1qpqdKrdZZXaDLxd 2w9A== X-Gm-Message-State: AODbwcCUv/UA+1LKT9e/5f3LxUOqJjuVrWdgpEqa9KZenA43oGAfqG8N 5CRB5maLv/+NioBx9Qo= X-Received: by 10.98.49.198 with SMTP id x189mr41052282pfx.65.1497009355939; Fri, 09 Jun 2017 04:55:55 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:2042:3e8:d7ce:9b9c? (2001-44b8-31ae-7b01-2042-03e8-d7ce-9b9c.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:2042:3e8:d7ce:9b9c]) by smtp.gmail.com with ESMTPSA id l4sm2423379pgn.34.2017.06.09.04.55.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2017 04:55:55 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: mail/alpine new Makefile To: Marco Beishuizen Cc: freebsd-ports@freebsd.org References: <7b39bcd3-ee60-4ef9-ff4b-fdb35b3fad73@FreeBSD.org> From: Kubilay Kocak Message-ID: <44822de4-f2f8-d71b-e58a-e15860519563@FreeBSD.org> Date: Fri, 9 Jun 2017 21:51:15 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 11:55:56 -0000 On 6/9/17 9:26 PM, Marco Beishuizen wrote: > On Fri, 9 Jun 2017, the wise Kubilay Kocak wrote: > >> On 6/9/17 7:41 PM, Marco Beishuizen wrote: >> >> Hi Marco, >> >> I believe the reason is: >> >>> .include >> >> The port includes this ^^^^ ... AND >> >> >> >>> .include >> >> This ---------^^^^^ >> >> Use one or the other, or neither if its *all* options helpers, but not >> both. See: >> >> https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html >> >> >> The paragraph just above the "Example 5.28. Simple Use of OPTIONS" > > Thanks Kubilay. I've removed the ".include changed the ".include " line at the end to ".include > ". It still builds and installs but the options that are > set are still not built in. I think I had a brainfail, and I believe it is in-fact fine to use both (if necessary) and the wording of the handbook might need to be tweaked not to imply it. That aside, I can't see use (testing) of PORT_OPTIONS:M or other variables that pre/post.mk inclusion is needed for, so neither bsd.port.options nor bsd.{pre,post}.mk appears to be necessary. That wouldn't seem to be the issue (though I could be wrong). Q: Does enabling/disabling OPTIONS change/add/remove CONFIGURE_ARGS for example? (make -V CONFIGURE_ARGS) Q: Is the make config dialog presenting OPTIONS correctly? Q: Once OPTIONS are saved, does /var/db/ports/category_portname/options accurately reflect the state changes? Q: Does make -V PORT_OPTIONS show/contain enabled options? ./koobs