From owner-svn-src-head@freebsd.org Sun Jun 2 14:10:22 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D025715B6BDE; Sun, 2 Jun 2019 14:10:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 70CEF6ACDC; Sun, 2 Jun 2019 14:10:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 054E594A0; Sun, 2 Jun 2019 14:10:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f170.google.com with SMTP id r76so13769094lja.12; Sun, 02 Jun 2019 07:10:20 -0700 (PDT) X-Gm-Message-State: APjAAAVyxyHVw4Is1xY0brKsxA+b+USqBdE+ud+lLbdTMWSUNe6Nhwec poV6S3aGR+dwumJyF8hgPDWBIWHiPzSGRdFvBcA= X-Google-Smtp-Source: APXvYqyO6WODcjrdxR+Z4pY7zmfr9jElB7XAayrQG1qdbmEn4+oj6B4cW1URDLIvzFdI0244S7zXQX1LnDqwS6u7tgI= X-Received: by 2002:a2e:2f12:: with SMTP id v18mr11109081ljv.196.1559484619555; Sun, 02 Jun 2019 07:10:19 -0700 (PDT) MIME-Version: 1.0 References: <201906020404.x5244MoT052965@repo.freebsd.org> <20190602115634.j2cj2fr37p5c5sc2@mutt-hbsd> In-Reply-To: <20190602115634.j2cj2fr37p5c5sc2@mutt-hbsd> From: Kyle Evans Date: Sun, 2 Jun 2019 09:10:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r348504 - in head: lib/clang/libllvm tools/build/mk usr.bin/clang To: Shawn Webb Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 70CEF6ACDC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.919,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 14:10:22 -0000 On Sun, Jun 2, 2019 at 6:56 AM Shawn Webb wrote: > > On Sun, Jun 02, 2019 at 04:04:21AM +0000, Kyle Evans wrote: > > Author: kevans > > Date: Sun Jun 2 04:04:21 2019 > > New Revision: 348504 > > URL: https://svnweb.freebsd.org/changeset/base/348504 > > > > Log: > > llvm-symbolizer: Move out of CLANG_EXTRAS, into CLANG > > > > ASAN reports become a lot more useful with llvm-symbolizer in $PATH, and the > > build is not much more time-consuming. The added benefit is that the > > resulting reports will actually include symbol information; without, thread > > trace information includes a bunch of addresses that immediately resolve to > > an inline function in > > ^/contrib/compiler-rt/lib/sanitizer_common/sanitizer_common.h and take a > > little more effort to examine. > > > > Reviewed by: emaste > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D20484 > > > > Modified: > > head/lib/clang/libllvm/Makefile > > head/tools/build/mk/OptionalObsoleteFiles.inc > > head/usr.bin/clang/Makefile > > > > Modified: head/lib/clang/libllvm/Makefile > > ============================================================================== > > --- head/lib/clang/libllvm/Makefile Sun Jun 2 02:38:44 2019 (r348503) > > +++ head/lib/clang/libllvm/Makefile Sun Jun 2 04:04:21 2019 (r348504) > > @@ -523,7 +523,7 @@ SRCS_EXT+= DebugInfo/PDB/PDBSymbolTypeVTableShape.cpp > > SRCS_EXT+= DebugInfo/PDB/PDBSymbolUnknown.cpp > > SRCS_EXT+= DebugInfo/PDB/PDBSymbolUsingNamespace.cpp > > SRCS_EXT+= DebugInfo/PDB/UDTLayout.cpp > > -SRCS_EXT+= DebugInfo/Symbolize/DIPrinter.cpp > > +SRCS_MIW+= DebugInfo/Symbolize/DIPrinter.cpp > > SRCS_MIW+= DebugInfo/Symbolize/SymbolizableObjectFile.cpp > > SRCS_MIW+= DebugInfo/Symbolize/Symbolize.cpp > > Is SRCS_MIW the right spelling? > Yup. Here's my understanding from looking at usage: SRCS_MIN = Absolute minimum set of src to build libllvm for bootstrap tools (MIN = MINimum) SRCS_MIW = Anything else needed to build libllvm for world tools (MIW = MIn World) Thanks, Kyle Evans