From owner-freebsd-ports@FreeBSD.ORG Wed Sep 16 21:58:04 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEB5F1065670 for ; Wed, 16 Sep 2009 21:58:04 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (113901-app1.sourcehosting.net [72.32.213.11]) by mx1.freebsd.org (Postfix) with ESMTP id 98E568FC13 for ; Wed, 16 Sep 2009 21:58:04 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=cube.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.69 (FreeBSD)) (envelope-from ) id 1Mo2Vi-000MAp-4S; Wed, 16 Sep 2009 17:58:03 -0400 Received: from [127.0.0.1] (fireball.entropy.prv [192.168.1.12]) by cube.entropy.prv (Postfix) with ESMTP id E19BF34A7DE7; Wed, 16 Sep 2009 17:57:57 -0400 (EDT) Message-ID: <4AB15F66.2070406@FreeBSD.org> Date: Wed, 16 Sep 2009 17:57:58 -0400 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Christian Weisgerber References: <20090916202317.GB91963@atarininja.org> <20090916210153.GA93138@lorvorc.mips.inka.de> In-Reply-To: <20090916210153.GA93138@lorvorc.mips.inka.de> X-Enigmail-Version: 0.96.0 OpenPGP: id=1C940290 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) Cc: Wesley Shields , freebsd-ports@FreeBSD.org Subject: Re: NOPORTDOCS ignored on command line X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2009 21:58:04 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Christian Weisgerber wrote: > Wesley Shields: > >> Are you seeing any particular problem on any particular port? > > Yes, but I haven't committed it yet. > >> wxs@rst wxs % cat Makefile >> all: >> .if defined(NOPORTDOCS) >> @echo "defined" >> .else >> @echo "not defined" >> .endif > > I have this: > > .if !defined(NOPORTDOCS) > INSTALL_TARGET= install install-dist_docDATA > .endif > > However, when I run "make -DNOPORTDOCS install", the install-dist_docDATA > target is still executed! > > So I have now added this snippet for debugging: > > do-install: > @echo ${INSTALL_TARGET}; exit 1 > > $ make -DNOPORTDOCS -V INSTALL_TARGET > install > $ make -DNOPORTDOCS install > ===> Installing for xz-4.999.9 > ===> Generating temporary packing list > ===> Checking if archivers/xz already installed > ===> Switching to root credentials for 'install' target > install install-dist_docDATA > *** Error code 1 > > Presumably bsd.port.mk invokes a recursive make for the install > step, but fails to pass NOPORTDOCS. > Hi Christian, I handled the docDATA/NOPORTDOCS problem in the GraphicsMagick12 port with the following excerpt from the Makefile: .if defined(NOPORTDOCS) # Get rid of the Makefile targets that install the documentation # and HTML files into DOCSDIR EXTRA_PATCHES+= ${FILESDIR}/extra-patch-Makefile.in .endif My files/extra-patch-Makefile.in contains: - --- Makefile.in.orig 2008-11-19 17:40:16.000000000 -0500 +++ Makefile.in 2008-11-19 17:40:58.000000000 -0500 @@ -9322,7 +9322,7 @@ info-am: install-data-am: install-codersLTLIBRARIES install-configlibDATA \ - - install-configshareDATA install-data-local install-docDATA \ + install-configshareDATA install-data-local \ install-filtersLTLIBRARIES install-includeHEADERS \ install-ltdlincludeHEADERS install-magickincHEADERS \ install-magickppincHEADERS install-magickpptopincHEADERS \ @@ -9671,8 +9671,7 @@ $(UTILITIES_INSTALL_EXEC_LOCAL_TARGETS) install-data-local: $(MAGICK_INSTALL_DATA_LOCAL_TARGETS) \ - - $(PERLMAGICK_INSTALL_DATA_LOCAL_TARGETS) \ - - $(HTML_INSTALL_DATA_TARGETS) + $(PERLMAGICK_INSTALL_DATA_LOCAL_TARGETS) uninstall-local: $(MAGICK_UNINSTALL_LOCAL_TARGETS) \ $(PERLMAGICK_UNINSTALL_LOCAL_TARGETS) \ There may be other ways to do it, but this worked well for me. Hope it helps, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/sourcehosting/ - Follow me, follow you -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFKsV9m0sRouByUApARAn7CAJ0et87tPmBI+8YPdCtAHhK4OYVS/ACcDQrm byic5vM74Hn4z3DEkEr5e2g= =b0JX -----END PGP SIGNATURE-----