From owner-svn-ports-head@FreeBSD.ORG Fri Feb 28 19:21:56 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5086E6FA for ; Fri, 28 Feb 2014 19:21:56 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C458C1D24 for ; Fri, 28 Feb 2014 19:21:55 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MGip3-1WO7iP0Puz-00DVix for ; Fri, 28 Feb 2014 20:21:48 +0100 Message-ID: <5310E1CA.1000504@gmx.de> Date: Fri, 28 Feb 2014 20:21:46 +0100 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Martin Wilke Subject: Re: svn commit: r346541 - head/www/mod_log_sql2 References: <201402281619.s1SGJBFL065513@svn.freebsd.org> In-Reply-To: <201402281619.s1SGJBFL065513@svn.freebsd.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:cwPYr5xZn97O0vZTGtXwuE5rmMjxRu8FlUOvgs2P1Xs/9vR2m/d ZZrA1V2ftNdygRhWvgB0DlltThBZStWsrjS663oeYZK/3HVN+IcIAu5sRMyb8LffsueqM4G HJDIB/VFAyFod5N2ZXoZu1gA6flBWv1xWbmJim6HdHWL9195ls/tegSCfrtOmsEQzsGHhZ1 rxVhnyQJem8tP5q/Ijqnw== Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2014 19:21:56 -0000 On 2014-02-28 17:19, Martin Wilke wrote: > Author: miwi > Date: Fri Feb 28 16:19:10 2014 > New Revision: 346541 > URL: http://svnweb.freebsd.org/changeset/ports/346541 > QAT: https://qat.redports.org/buildarchive/r346541/ > > Log: > - Stage support > > Modified: > head/www/mod_log_sql2/Makefile > > Modified: head/www/mod_log_sql2/Makefile > ============================================================================== > --- head/www/mod_log_sql2/Makefile Fri Feb 28 16:18:59 2014 (r346540) > +++ head/www/mod_log_sql2/Makefile Fri Feb 28 16:19:10 2014 (r346541) > @@ -25,7 +25,6 @@ USE_MYSQL= yes > USE_APACHE= 22 > CONFIGURE_ENV+= LIBS="-L${LOCALBASE}/lib -L${LOCALBASE}/lib/mysql" > > -NO_STAGE= yes > .include > > .if defined(WITH_DBI) || exists(${LOCALBASE}/include/dbi/dbi.h) > @@ -39,6 +38,6 @@ SSL_PLIST= "@comment " > .endif > > post-install: > - @${APXS} -e -a -n "${SHORTMODNAME}" "${APACHEMODDIR}/${MODULENAME}.so" > + @${APXS} -e -a -n "${SHORTMODNAME}" "${STAGEDIR}${APACHEMODDIR}/${MODULENAME}.so" > > .include > Hi Martin, this will not work as expected, that's why this port is was not converted. The makefile from mod_log_sql will try to install all three modules into ${PREFIX}/${APACHEMODDIR} and not into ${STAGEDIR}${PREFIX}/${APACHEMODDIR}. The changed APXS line does not install mod_log_sql, it will enable the module in httpd.conf (param -e -a) (even during make stage) In case someone will run 'make stage' with sudo or as root the httpd.conf will messed up with a non installed module. The only way to enable staging for this port is to patch the Makefile.in by changing the apcs instructions from - 'apxs -n $(SHORTMODNAME) -i $(MODULENAME).la' to + 'apxs -S LIBEXECDIR=${STAGEDIR}${PREFIX}/${APACHEMODDIR} -n $(SHORTMODNAME) -i $(MODULENAME).la' for mod_log_sql_mysql, mod_log_sql_logio and mod_log_sql_ssl -- Regards, olli