From owner-freebsd-bugs Tue Nov 12 10:14:38 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A262C37B401; Tue, 12 Nov 2002 10:14:37 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5318A43E7B; Tue, 12 Nov 2002 10:14:37 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from freefall.freebsd.org (jhb@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gACIEbx3039971; Tue, 12 Nov 2002 10:14:37 -0800 (PST) (envelope-from jhb@freefall.freebsd.org) Received: (from jhb@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gACIEVpM039965; Tue, 12 Nov 2002 10:14:31 -0800 (PST) Date: Tue, 12 Nov 2002 10:14:31 -0800 (PST) From: John Baldwin Message-Id: <200211121814.gACIEVpM039965@freefall.freebsd.org> To: traister@mojozone.org, jhb@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/5419: [PATCH] timed rejects valid networks with -n Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Synopsis: [PATCH] timed rejects valid networks with -n State-Changed-From-To: suspended->closed State-Changed-By: jhb State-Changed-When: Tue Nov 12 10:12:08 PST 2002 State-Changed-Why: Not a bug. timed -n works fine as it is. Note that the network '127' is not valid however. The timed code relies on nt->net being in host byte order later on in the loop when it uses shifts to adjust networks such as 0x0000007f (127) to 0x7f000000 (127.0.0.0). Later on when comparing network addresses htonl() is already used as noted in the follow-up e-mail. http://www.freebsd.org/cgi/query-pr.cgi?pr=5419 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message