From owner-svn-src-head@FreeBSD.ORG  Wed Sep 26 07:55:40 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 661901065679;
	Wed, 26 Sep 2012 07:55:40 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
	by mx1.freebsd.org (Postfix) with ESMTP id 285B78FC14;
	Wed, 26 Sep 2012 07:55:39 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
	by mail.dawidek.net (Postfix) with ESMTPSA id B1C667D7;
	Wed, 26 Sep 2012 09:54:39 +0200 (CEST)
Date: Wed, 26 Sep 2012 09:56:03 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Ed Maste <emaste@FreeBSD.org>
Message-ID: <20120926075603.GK1391@garage.freebsd.pl>
References: <201209252210.q8PMAEx5003950@svn.freebsd.org>
	<20120926075442.GJ1391@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="lZZ4ablUVnt2XgAh"
Content-Disposition: inline
In-Reply-To: <20120926075442.GJ1391@garage.freebsd.pl>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r240938 - head/sys/net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2012 07:55:40 -0000


--lZZ4ablUVnt2XgAh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 26, 2012 at 09:54:43AM +0200, Pawel Jakub Dawidek wrote:
> On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote:
> [...]
> >   Note: if_tun had the same issue, addressed in SVN revisions r186391,
> >   r186483 and r186497.  The use of the condvar there appears to be
> >   redundant with the functionality provided by destroy_dev.
> [...]
> > --- head/sys/net/if_tapvar.h	Tue Sep 25 21:33:36 2012	(r240937)
> > +++ head/sys/net/if_tapvar.h	Tue Sep 25 22:10:14 2012	(r240938)
> > @@ -64,6 +64,7 @@ struct tap_softc {
> >  	SLIST_ENTRY(tap_softc)	tap_next;	/* next device in chain      */
> >  	struct cdev *tap_dev;
> >  	struct mtx	 tap_mtx;		/* per-softc mutex */
> > +	struct cv	 tap_cv;		/* protect ref'd dev destroy */=20
> >  };
>=20
> So maybe there is no need to add it?:)

I'm sooo late, sorry.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--lZZ4ablUVnt2XgAh
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlBitRIACgkQForvXbEpPzSo0wCdHWAdrwD3X47CuUqHYksdobMo
yVkAnRyXcdrPnSBLgiPownREMTOQtCxb
=jLtE
-----END PGP SIGNATURE-----

--lZZ4ablUVnt2XgAh--