From owner-freebsd-current@FreeBSD.ORG Mon Apr 23 17:31:12 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2E33106566C for ; Mon, 23 Apr 2012 17:31:12 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from zimbra.averesystems.com (75-149-8-245-Pennsylvania.hfc.comcastbusiness.net [75.149.8.245]) by mx1.freebsd.org (Postfix) with ESMTP id 4E0658FC15 for ; Mon, 23 Apr 2012 17:31:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zimbra.averesystems.com (Postfix) with ESMTP id 9CD37446005 for ; Mon, 23 Apr 2012 13:30:46 -0400 (EDT) X-Virus-Scanned: amavisd-new at averesystems.com Received: from zimbra.averesystems.com ([127.0.0.1]) by localhost (zimbra.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id veJ-NW2PI-jt; Mon, 23 Apr 2012 13:30:44 -0400 (EDT) Received: from riven.arriad.com (fw.arriad.com [10.0.0.16]) by zimbra.averesystems.com (Postfix) with ESMTPSA id 58020446003; Mon, 23 Apr 2012 13:30:44 -0400 (EDT) From: Andrew Boyer Mime-Version: 1.0 (Apple Message framework v1084) Date: Mon, 23 Apr 2012 13:31:03 -0400 References: <3C479FEC-971A-4099-9CA5-B522574BE763@averesystems.com> To: Current FreeBSD Message-Id: X-Mailer: Apple Mail (2.1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Greg Bednarek Subject: Fwd: Memory leak in authunix_create_default()... X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 17:31:12 -0000 Begin forwarded message: > From: Greg Bednarek > Date: April 16, 2012 10:54:33 AM EDT > To: freebsd-current@freebsd.org > Cc: Andrew Boyer > Subject: Memory leak in authunix_create_default()... >=20 >=20 > Please see the attached patch for a proposed fix for a memory leak in = authunix_create_default(). >=20 > The leak appears to have been introduced 6/19/2009 in Revision 194494 = of lib/libc/rpc/auth_unix.c >=20 > As you can see form the patch, the fix is very simple. The issue was = discovered when tracking down some rather drastic increases in = application memory footprint during certain types of workloads, and was = eventually traced it to this (apparently) not very heavily used path in = libc. >=20 > I would appreciate hearing any comments/concerns with the proposed = fix. >=20 >=20 >=20 > Regards, >=20 > Greg Bednarek >=20 >=20 > --- > Greg Bednarek > phone: 412-635-7170 x257 > fax: 412-635-7171 > email: gbednarek@averesystems.com >=20 >=20 >=20 >=20 >=20 This got caught up in moderation and never reached the list. -Andrew -------------------------------------------------- Andrew Boyer aboyer@averesystems.com