From owner-freebsd-bugs@FreeBSD.ORG  Tue May 31 04:30:02 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6C17716A41C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 31 May 2005 04:30:02 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 206B743D53
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 31 May 2005 04:30:02 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4V4U10h078087
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 31 May 2005 04:30:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4V4U1BJ078063;
	Tue, 31 May 2005 04:30:01 GMT (envelope-from gnats)
Resent-Date: Tue, 31 May 2005 04:30:01 GMT
Resent-Message-Id: <200505310430.j4V4U1BJ078063@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Gil Kloepfer <fgil@kloepfer.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A025816A41F
	for <FreeBSD-gnats-submit@freebsd.org>;
	Tue, 31 May 2005 04:24:04 +0000 (GMT)
	(envelope-from gil@kloepfer.org)
Received: from limbic.kloepfer.org (limbic.kloepfer.org [67.65.12.9])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 96B4543D48
	for <FreeBSD-gnats-submit@freebsd.org>;
	Tue, 31 May 2005 04:24:03 +0000 (GMT)
	(envelope-from gil@kloepfer.org)
Received: from limbic.kloepfer.org (localhost.kloepfer.org [127.0.0.1])
	by limbic.kloepfer.org (8.13.3/8.13.3) with ESMTP id j4V4O2jr089968;
	Mon, 30 May 2005 23:24:02 -0500 (CDT)
Received: (from gil@localhost)
	by limbic.kloepfer.org (8.13.3/8.13.3/Submit) id j4V4O2aq089967;
	Mon, 30 May 2005 23:24:02 -0500 (CDT)
	(envelope-from gil@kloepfer.org)
Message-Id: <200505310424.j4V4O2aq089967@limbic.kloepfer.org>
Date: Mon, 30 May 2005 23:24:02 -0500 (CDT)
From: Gil Kloepfer <fgil@kloepfer.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: 
Subject: bin/81692: [patch] atacontrol support for disk APM and acoustic
	management
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Gil Kloepfer <fgil@kloepfer.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 May 2005 04:30:02 -0000


>Number:         81692
>Category:       bin
>Synopsis:       [patch] atacontrol support for disk APM and acoustic management
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 31 04:30:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Gil Kloepfer
>Release:        FreeBSD 5.4-RELEASE i386
>Organization:
Self
>Environment:
System: FreeBSD limbic.kloepfer.org 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Sun May 22 12:52:26 CDT 2005 root@build.int.kloepfer.org:/usr/src/sys/i386/compile/DELLDIM i386

>Description:
Attached is a patch to enhance atacontrol so that it may
control an ATA hard disk's advanced power management (APM) and
acoustic management features.  The former is typically important
with laptop/notebook hard disks where the drives are designed
to operate in low power mode by default.  For systems where
this is not important, it can lead to the drive constantly
spinning up-and-down, leading to reduced performance.  This
feature can also be used to enable power management where it
is not enabled by default.

Acoustic management functions similarly.

Note that /usr/include/sys/ata.h (in the source as
sys/sys/ata.h) is modified to include the appropriate
symbolic representation of the APM and acoustic feature
codes from the ATA specification.

>How-To-Repeat:
This is not a bug, so there's nothing to repeat.

>Fix:
The following patch is uuencoded in order to prevent modification
by e-mail servers.  It patches the following files:

(based in /usr/src)
sbin/atacontrol/atacontrol.c
sbin/atacontrol/atacontrol.8
sys/sys/ata.h

(yes, I really did include the additions to the manpage!!)

begin 644 atapatch
M+2TM('-B:6XO871A8V]N=')O;"]A=&%C;VYT<F]L+F,N3U))1PE4:'4@36%Y
M(#(P(#$P.C`Q.C(V(#(P,#0**RLK('-B:6XO871A8V]N=')O;"]A=&%C;VYT
M<F]L+F,)36]N($UA>2`S,"`R,CHS,CHQ,"`R,#`U"D!`("TU,34L-B`K-3$U
M+#<P($!`"B`)"0D);6]D93)S='(H:6]C;60N=2YM;V1E+FUO9&5;,5TI*3L*
M(`D)?0H@"7T**PEE;'-E(&EF("@A<W1R8VUP*&%R9W9;,5TL(")F96%T=7)E
M(BD@)B8@87)G8R`]/2`V*2!["BL)"6EO8VUD+F1E=FEC92`](&%T;VDH87)G
M=ELS72D["BL)"6EO8VUD+F-M9"`]($%405)%455%4U0["BL)"6EO8VUD+G4N
M<F5Q=65S="YU+F%T82YC;VUM86YD(#T@051!7U-%5$9%05154D53.PHK"0EI
M;V-M9"YU+G)E<75E<W0N=&EM96]U="`](#4P,#L**PD):68@*"%S=')C;7`H
M87)G=ELT72P@(F%P;2(I*2!["BL)"0EI9B`H(7-T<F-M<"AA<F=V6S5=+"`B
M;V9F(BDI('L**PD)"0EI;V-M9"YU+G)E<75E<W0N=2YA=&$N9F5A='5R92`]
M($%405]31E]$25-?05!-.PHK"0D)?0HK"0D)96QS92!I9B`H(7-T<F-M<"AA
M<F=V6S5=+"`B;6%X<&5R9B(I*2!["BL)"0D):6]C;60N=2YR97%U97-T+G4N
M871A+F9E871U<F4@/2!!5$%?4T9?14Y!0E]!4$T["BL)"0D):6]C;60N=2YR
M97%U97-T+G4N871A+F-O=6YT(#T@,'AF93L**PD)"7T**PD)"65L<V4@:68@
M*"%S=')C;7`H87)G=ELU72P@(FUI;G!O=V5R(BDI('L**PD)"0EI;V-M9"YU
M+G)E<75E<W0N=2YA=&$N9F5A='5R92`]($%405]31E]%3D%"7T%033L**PD)
M"0EI;V-M9"YU+G)E<75E<W0N=2YA=&$N8V]U;G0@/2`P>#`Q.PHK"0D)?0HK
M"0D)96QS92!["BL)"0D):6YT(&]F9G-E="`](#`["BL**PD)"0EI;V-M9"YU
M+G)E<75E<W0N=2YA=&$N9F5A='5R92`]($%405]31E]%3D%"7T%033L**PD)
M"0EI9B`H87)G=ELU75LP72`]/2`G<R<I('L**PD)"0D);V9F<V5T(#T@871O
M:2@F87)G=ELU75LQ72D["BL)"0D)"6EO8VUD+G4N<F5Q=65S="YU+F%T82YC
M;W5N="`](#!X,#$["BL)"0D)?2!E;'-E('L**PD)"0D);V9F<V5T(#T@871O
M:2@F87)G=ELU75LQ72D["BL)"0D)"6EO8VUD+G4N<F5Q=65S="YU+F%T82YC
M;W5N="`](#!X.#`["BL)"0D)?0HK"0D)"6EF("AO9F9S970@/CT@,"`F)B!O
M9F9S970@/#T@,3(W*0HK"0D)"0EI;V-M9"YU+G)E<75E<W0N=2YA=&$N8V]U
M;G0@*ST@;V9F<V5T.PHK"0D)?0HK"0E]"BL)"65L<V4@:68@*"%S=')C;7`H
M87)G=ELT72P@(F%C;W5S=&EC(BDI('L**PD)"6EF("@A<W1R8VUP*&%R9W9;
M-5TL(")O9F8B*2D@>PHK"0D)"6EO8VUD+G4N<F5Q=65S="YU+F%T82YF96%T
M=7)E(#T@051!7U-&7T1)4U]!0T-/55,["BL)"0E]"BL)"0EE;'-E(&EF("@A
M<W1R8VUP*&%R9W9;-5TL(")M87AP97)F(BDI('L**PD)"0EI;V-M9"YU+G)E
M<75E<W0N=2YA=&$N9F5A='5R92`]($%405]31E]%3D%"7T%#0T]54SL**PD)
M"0EI;V-M9"YU+G)E<75E<W0N=2YA=&$N8V]U;G0@/2`P>&9E.PHK"0D)?0HK
M"0D)96QS92!I9B`H(7-T<F-M<"AA<F=V6S5=+"`B;6%X<75I970B*2D@>PHK
M"0D)"6EO8VUD+G4N<F5Q=65S="YU+F%T82YF96%T=7)E(#T@051!7U-&7T5.
M04)?04-#3U53.PHK"0D)"6EO8VUD+G4N<F5Q=65S="YU+F%T82YC;W5N="`]
M(#!X.#`["BL)"0E]"BL)"0EE;'-E('L**PD)"0EI;V-M9"YU+G)E<75E<W0N
M=2YA=&$N9F5A='5R92`]($%405]31E]%3D%"7T%#0T]54SL**PD)"0EI;V-M
M9"YU+G)E<75E<W0N=2YA=&$N8V]U;G0@/2!A=&]I*&%R9W9;-5TI.PHK"0D)
M"6EF("AI;V-M9"YU+G)E<75E<W0N=2YA=&$N8V]U;G0@/B`Q,C0I"BL)"0D)
M"6EO8VUD+G4N<F5Q=65S="YU+F%T82YC;W5N="`](#$R-#L**PD)"7T**PD)
M?0HK"0EE;'-E"BL)"0EU<V%G92@I.PHK"BL)"6EF("AI;V-T;"AF9"P@24]#
M051!+"`F:6]C;60I(#P@,"D**PD)"65R<B@Q+"`B:6]C=&PH051!4D515453
M5"DB*3L**PHK"0EI9B`H:6]C;60N=2YR97%U97-T+F5R<F]R("$](#`I('L*
M*PD)"69P<FEN=&8H<W1D97)R+`HK"0D)"2)!5$%215%515-4(')E='5R;F5D
M(&5R<B!S=&%T=7,@)60B+`HK"0D)"6EO8VUD+G4N<F5Q=65S="YE<G)O<BD[
M"BL)"0EE>&ET*#$I.PHK"0E]"BL)?0H@"65L<V4*(`D)=7-A9V4H*3L*(`EE
M>&ET*$587T]+*3L*+2TM('-B:6XO871A8V]N=')O;"]A=&%C;VYT<F]L+C@N
M3U))1PE&<FD@2G5L("`R(#$V.C0U.C`P(#(P,#0**RLK('-B:6XO871A8V]N
M=')O;"]A=&%C;VYT<F]L+C@)36]N($UA>2`S,"`R,CHU.#HS-"`R,#`U"D!`
M("TW,2PV("LW,2PQ-B!`0`H@+DEC(&-A<`H@+D%R(&-H86YN96P@9&5V:6-E
M"B`N3FT**RY)8R!F96%T=7)E"BLN07(@8VAA;FYE;"!D979I8V4**RY)8R!A
M<&T**RY!<B!A<&UL979E;`HK+DYM"BLN26,@9F5A='5R90HK+D%R(&-H86YN
M96P@9&5V:6-E"BLN26,@86-O=7-T:6,**RY!<B!S;W5N9'-U<'!L979E;`HK
M+DYM"B`N26,@96YC;&]S=7)E"B`N07(@8VAA;FYE;"!D979I8V4*("Y.;0I`
M0"`M,C`V+#8@*S(Q-BPT."!`0`H@4VAO=R!D971A:6QE9"!I;F9O(&%B;W5T
M('1H92!D979I8V4@;VX*("Y!<B!C:&%N;F5L(&1E=FEC90H@=VAE<F4@9&5V
M:6-E(&ES(#`@9F]R(&UA<W1E<B!A;F0@,2!F;W(@<VQA=F4N"BLN270@26,@
M9F5A='5R92`O(&%P;0HK4V5T(&1I<VL@9')I=F4@061V86YC960@4&]W97(@
M36%N86=E;65N="`H05!-*2!L979E;"!O;@HK+D%R(&-H86YN96P@9&5V:6-E
M"BMW:&5R92!D979I8V4@:7,@,"!F;W(@;6%S=&5R(&%N9"`Q(&9O<B!S;&%V
M92X@(%1H:7,@8V]M;6%N9`HK:7,@9V5N97)A;&QY('5S960@;VX@;&%P=&]P
M("AN;W1E8F]O:RD@:&%R9"!D:7-K<R!T;R!C;VYT<F]L"BMT:&4@<&]W97(@
M;&5V96P@8V]N<W5M960@8GD@=&AE(&1R:79E("AA="!T:&4@97AP96YS92!O
M9B!P97)F;W)M86YC92DN"BLN4'`**U1H90HK+D%R(&%P;6QE=F5L"BMM87D@
M8F4@<V5T('1O(&]N92!O9CH**RY#;2!O9F8**RAT=7)N(&]F9B!!4$TI+`HK
M+D-M(&UA>'!E<F8**V]R"BLN0VT@;6EN<&]W97(**RAO<'1I;6EZ92!F;W(@
M;6%X:6UU;2!P97)F;W)M86YC92!O<B!M:6YI;75M('!O=V5R+"!R97-P96-T
M:79E;'DI+"!O<@HK82!N=6UE<FEC(&QE=F5L('=H:6-H(&-A;B!B92`P('1O
M(#$R-R!I;F-L=7-I=F4@:6YD:6-A=&EN9R!A;B!I;F-R96%S:6YG"BML979E
M;"!O9B!P97)F;W)M86YC92!O=F5R('!O=V5R('-A=FEN9W,N"BM4:&4@;G5M
M97)I8R!L979E;',@;6%Y(&)E('!R969I>&5D(&)Y"BLN0VT@<PHK=VAI8V@@
M=VEL;"!A;&QO=R!T:&4@9')I=F4@=&\@:6YC;'5D92!S=7-P96YS:6]N(&%S
M('!A<G0@;V8@=&AE"BMP;W=E<B!S879I;F=S+B`@3F]T92!T:&%T(&YO="!A
M;&P@:&%R9"!D<FEV97,@=VEL;"!S=7!P;W)T('1H90HK+D-M(&]F9@HK8V]M
M;6%N9"P@86YD('1H870@=&AE(&YU;6)E<B!O9B!I;F-R96UE;G1A;"!P;W=E
M<B!S879I;F=S(&QE=F5L<PHK9&\@;F]T('1Y<&EC86QL>2!H879E(&%S('=I
M9&4@;V8@82!R86YG92!A<R!T:&ES(&-O;6UA;F0@=VEL;`HK<W5P<&]R="X*
M*RY)="!)8R!F96%T=7)E("\@86-O=7-T:6,**T-O;G1R;VP@9&ES:R!D<FEV
M92!!8V]U<W1I8R!-86YA9V5M96YT(&QE=F5L(&]N"BLN07(@8VAA;FYE;"!D
M979I8V4**W=H97)E(&1E=FEC92!I<R`P(&9O<B!M87-T97(@86YD(#$@9F]R
M('-L879E+B`@5&AE"BLN07(@<V]U;F1S=7!P;&5V96P**VUA>2!B92!S970@
M=&\**RY#;2!O9F8**W=H:6-H('=I;&P@='5R;B!O9F8@86-O=7-T:6,@;6%N
M86=E;65N="P**RY#;2!M87AP97)F"BMT;R!O<'1I;6EZ92!F;W(@;6%X:6UU
M;2!P97)F;W)M86YC92P**RY#;2!M87AQ=6EE=`HK=&\@;W!T:6UI>F4@9F]R
M(&UA>&EM=6T@<75I970L(&]R(&$@;G5M97)I8R!L979E;`HK9G)O;2`P('1O
M(#$R-"X@(%1H92!H:6=H97(@=&AE(&YU;65R:6,@;&5V96PL('1H92!H:6=H
M97(@=&AE"BMT:&5O<F5T:6-A;"!S;W5N9"!L979E;"!E;6ET=&5D(&9R;VT@
M=&AE(&1R:79E+B`@3F]T92!T:&%T(&9E=PHK9&5V:6-E<R!S=7!P;W)T('1H
M:7,@8V]M;6%N9"!A;F0@979E;B!F97=E<B!W:6QL(&%L;&]W('1H90HK<F%N
M9V4@;V8@;&5V96QS('-U<'!O<G1E9"X*("Y)="!)8R!E;F-L;W-U<F4*(%-H
M;W<@9&5T86EL960@:6YF;R!A8F]U="!T:&4@96YC;&]S=7)E(&]N"B`N07(@
M8VAA;FYE;"!D979I8V4*+2TM('-Y<R]S>7,O871A+F@N3U))1PE4:'4@36%Y
M(#(P(#$P.C`Y.C0Q(#(P,#0**RLK('-Y<R]S>7,O871A+F@)36]N($UA>2`S
M,"`R,SHP-SHQ.2`R,#`U"D!`("TR-3$L-B`K,C4Q+#$P($!`"B`C9&5F:6YE
M"0E!5$%?4T9?1$E37U)%3$E240DP>&1D"2\J(&1I<V%B;&4@<F5L96%S92!I
M;G1E<G)U<'0@*B\*("-D969I;F4)"4%405]31E]%3D%"7U-25DE240DP>#5E
M"2\J(&5N86)L92!S97)V:6-E(&EN=&5R<G5P="`J+PH@(V1E9FEN90D)051!
M7U-&7T1)4U]34E9)4E$),'AD90DO*B!D:7-A8FQE('-E<G9I8V4@:6YT97)R
M=7!T("HO"BLC9&5F:6YE"0E!5$%?4T9?14Y!0E]!4$T)"3!X,#4)+RH@96YA
M8FQE(&%D=B!P;W=E<B!M9VUT("HO"BLC9&5F:6YE"0E!5$%?4T9?1$E37T%0
M30D),'@X-0DO*B!D:7-A8FQE(&%D=B!P;W=E<B!M9VUT("HO"BLC9&5F:6YE
M"0E!5$%?4T9?14Y!0E]!0T-/55,),'@T,@DO*B!E;F%B;&4@86-O=7-T:6,@
M;6=M="`J+PHK(V1E9FEN90D)051!7U-&7T1)4U]!0T-/55,),'AC,@DO*B!D
M:7-A8FQE(&%C;W5S=&EC(&UG;70@*B\*(`H@+RH@051!4$D@8V]M;6%N9',@
M*B\*("-D969I;F4@051!4$E?5$535%]53DE47U)%0419"0DP>#`P"2\J(&-H
:96-K(&EF(&1E=FEC92!I<R!R96%D>2`J+PH`
`
end
>Release-Note:
>Audit-Trail:
>Unformatted: