Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Nov 2012 23:26:36 +0100
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/173569: [PATCH] graphics/icon-slicer: OptionsNG, shorter pkg-descr, take maintainership
Message-ID:  <20121111222643.790D9907@hub.freebsd.org>
Resent-Message-ID: <201211112230.qABMU0vL047143@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         173569
>Category:       ports
>Synopsis:       [PATCH] graphics/icon-slicer: OptionsNG, shorter pkg-descr, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 11 22:30:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

- Take maintainership

Makefile changed:
+COMMENT=	Utility for generating icon and cursor themes
+LICENSE=	GPLv2
+PORTDOCS=	AUTHORS ChangeLog README TODO
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}

24 lines pkg-descr

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
looks fine.

port test: clean

Can't give build log, because RedPorts not works at the time.

>Fix:

--- icon-slicer-0.3_7.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/graphics/icon-slicer/Makefile ./Makefile
--- /usr/ports/graphics/icon-slicer/Makefile	2012-06-01 07:20:05.000000000 +0200
+++ ./Makefile	2012-11-11 23:15:26.000000000 +0100
@@ -11,8 +11,10 @@
 CATEGORIES=	graphics
 MASTER_SITES=	http://www.freedesktop.org/software/icon-slicer/releases/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	An utility for generating icon and cursor themes
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Utility for generating icon and cursor themes
+
+LICENSE=	GPLv2
 
 LIB_DEPENDS=	popt:${PORTSDIR}/devel/popt
 
@@ -23,19 +25,17 @@
 
 PLIST_FILES=	bin/icon-slicer
 
-.if !defined(NOPORTDOCS)
-PORTDOCS=	*
-.endif
+PORTDOCS=	AUTHORS ChangeLog README TODO
+
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e '/^SUBDIRS/ s|examples||' ${WRKSRC}/Makefile.in
 
-.if !defined(NOPORTDOCS)
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
-.for f in AUTHORS README TODO
-	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
-.endfor
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/graphics/icon-slicer/pkg-descr ./pkg-descr
--- /usr/ports/graphics/icon-slicer/pkg-descr	2009-12-21 03:17:02.000000000 +0100
+++ ./pkg-descr	2012-11-11 23:16:16.000000000 +0100
@@ -1,5 +1,4 @@
-icon-slicer is a utility for generating icon themes and libXcursor cursor
-themes.
+icon-slicer is a utility for generating icon themes and libXcursor cursor themes
 
 The inputs to icon-slicer are conceptually:
  
@@ -12,7 +11,6 @@
  - a layer with a dot for the hotspot of each cursor
  - the main image or first animation frame for multi-frame animated cursors
  - the second animation frame for multi-frame animated cursors
- - ...
 
 For icons, the layers are:
 
@@ -23,8 +21,4 @@
 In practice, since loading of multilayer images is not supported by standard
 image libraries, each layer is input as a separate image file.
 
-The theme description file contains, among other things, information about the
-source images to read, the location of each named cursor or icon within the
-grid, and a set of aliases from names to other names.
-
 WWW: http://www.freedesktop.org/wiki/Software/icon-slicer
--- icon-slicer-0.3_7.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121111222643.790D9907>