From owner-svn-ports-head@FreeBSD.ORG Sat May 4 14:24:58 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8F8DDB41 for ; Sat, 4 May 2013 14:24:58 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-da0-x22f.google.com (mail-da0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 663AD1D28 for ; Sat, 4 May 2013 14:24:58 +0000 (UTC) Received: by mail-da0-f47.google.com with SMTP id k13so1197377dae.6 for ; Sat, 04 May 2013 07:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Ict15q/KCtIuY6wJrbBg9X4AFthPX8QGdIq9DcgBqEU=; b=nvr5Ss65e02O9sfSzWPACfFdIvXL3L6lzUMp+U5MtM2/ECWT0gJGpyaqMWBEMBJAuf P7bReBKc4O7mkSHayP4qxQDcX4yGQHwvwJ8Lk2Tl+vQrg/8YgilXF2C23b2v7z3YjDOU MTlIiSRWqYSYyR7bkzoQTqG2CfqOiXFtcr/bE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=Ict15q/KCtIuY6wJrbBg9X4AFthPX8QGdIq9DcgBqEU=; b=NNamLPXpXF08FJ3XUSm8lyobTrfw353fms2ifi7Gqxlakl+4QdEdd7kFSyLbpnLhpg YiUfmdxFPdBkr84CX9R4n+H8zbghBN8LbJqVwzGIAr77w2KWOYRL5YdHSKbZg7718AyU 9GIQhdolAoqpVLUC6VWJJbbUbcEWrrvW6ZyokF8KRdYyxUpGSZT0eagq7iNoAF7Cbbp1 HazlqCOO51B37Yqzc+Hpnr1bG47IDHXLRO9KrF0vQLx96bQVnGS5qQzr40mopgblQjyS TnShkbGYDvhw2xR+vHe1n6/51qLsdb5TG/4DLUaJ9/p9yVkBJBxjXAdXo5MP8AengZBs i2RA== X-Received: by 10.66.102.70 with SMTP id fm6mr18737021pab.164.1367677498152; Sat, 04 May 2013 07:24:58 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.159.97 with HTTP; Sat, 4 May 2013 07:24:28 -0700 (PDT) In-Reply-To: <5185181E.9040104@FreeBSD.org> References: <201305041406.r44E69Bw096955@svn.freebsd.org> <5185181E.9040104@FreeBSD.org> From: Eitan Adler Date: Sat, 4 May 2013 10:24:28 -0400 X-Google-Sender-Auth: KcPXG9ouzpywJhrqfgqcp3b_MzI Message-ID: Subject: Re: svn commit: r317320 - in head: Mk audio/gmidimonitor audio/lv2core audio/patchage audio/raul audio/slv2 databases/dbf editors/libreoffice games/tuxmath games/tuxtype graphics/mapnik java/openjdk6 j... To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmi0Mn2kOqNmpQl1SCJc1OSkIJ6rn8Gyuha3bqUAcUd/zH3q/CdRh5JkFGgDRJaGxKsxg2z Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 May 2013 14:24:58 -0000 On 4 May 2013 10:15, Bryan Drewery wrote: > On 5/4/2013 9:12 AM, Eitan Adler wrote: >> On 4 May 2013 10:06, Bryan Drewery wrote: >>> Author: bdrewery >>> Date: Sat May 4 14:06:08 2013 >>> New Revision: 317320 >>> URL: http://svnweb.freebsd.org/changeset/ports/317320 >>> >>> Log: >>> - When DISABLE_MAKE_JOBS or MAKE_JOBS_UNSAFE is set, also set >>> MAKE_JOBS_NUMBER to 1. This makes it safe to do -j${MAKE_JOBS_NUMBER} >>> without any extra logic. >> >> No. It does not make this safe unless -B is also specified to make. >> >> It is possible that a Makefile will work with "make" but be buggy when >> "make -j1" is used. >> > > How is -j1 not safe? I test built these and they were fine. Its been a *long* time since I looked but I seem to remember that -j: - changes which features are available (disables 'compatibility mode') - changes the order in which certain dependencies are evaluated I am not saying that these ports will break, but that it is not a direct consequence: it needs to be tested each time. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams