From owner-cvs-all Sun Jan 17 07:41:29 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA27729 for cvs-all-outgoing; Sun, 17 Jan 1999 07:41:29 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from gratis.grondar.za (gratis.grondar.za [196.7.18.65]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA27713; Sun, 17 Jan 1999 07:41:22 -0800 (PST) (envelope-from mark@grondar.za) Received: from greenpeace.grondar.za (greenpeace.grondar.za [196.7.18.132]) by gratis.grondar.za (8.9.1/8.9.1) with ESMTP id RAA10337; Sun, 17 Jan 1999 17:41:15 +0200 (SAST) (envelope-from mark@grondar.za) Received: from grondar.za (localhost [127.0.0.1]) by greenpeace.grondar.za (8.9.2/8.9.2) with ESMTP id RAA05521; Sun, 17 Jan 1999 17:41:13 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <199901171541.RAA05521@greenpeace.grondar.za> To: "Andrey A. Chernov" cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/usr.bin/perl/libperl config.SH-aout.i386 config.SH-elf.alpha config.SH-elf.i386 In-Reply-To: Your message of " Sun, 17 Jan 1999 18:35:30 +0300." <19990117183530.A1460@nagual.pp.ru> References: <199901170953.BAA10010@freefall.freebsd.org> <19990117162723.A58648@nagual.pp.ru> <199901171503.RAA87113@greenpeace.grondar.za> <19990117183530.A1460@nagual.pp.ru> Date: Sun, 17 Jan 1999 17:41:12 +0200 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Andrey A. Chernov" wrote: > On Sun, Jan 17, 1999 at 05:03:07PM +0200, Mark Murray wrote: > > I fully understand that the current state-off-affairs does not work as it > > should. I reverted it because is broke "make world" or "make release" for > > some folks. > > What the breakage is exactly? Of course I test my change before commiting > it, but by simple perl rebuilding from clean state, not from 'make world'. In some folks' "make world", during the build of dynaloader, stdio.h was not found. *Boom* > > I intent to keep it there as a reminder to fix that line. > > The line works fine for libperl. > > As result perl *.so modules not optimized at all causing performance > problems :-( It was the reason why I change it... I agree this is a problem. :-) Any perl-build changes must be tested through _at_least_ a "make world", and I am coming to believe that it should also be run through a "make release" (I am prepared to admit that making this a requirement is on the difficult side, but if "make release" fails, then the commit gets tossed). M -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message