Date: Tue, 15 Feb 2011 13:18:41 -0800 From: Garrett Cooper <gcooper@FreeBSD.org> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org> Subject: Re: svn commit: r218716 - head/sys/boot/common Message-ID: <AANLkTinfg1GCsk5w%2BZTvqcuE0021ox%2ByQoKiTti5c0YL@mail.gmail.com> In-Reply-To: <20110215210817.GA64113@freebsd.org> References: <201102152101.p1FL1D5Z044262@svn.freebsd.org> <20110215210817.GA64113@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 15, 2011 at 1:08 PM, Roman Divacky <rdivacky@freebsd.org> wrote:
> I put there u_int8_t for a reason. That reason being that
> it's basically struct direct->d_type which is u_int8_t
> and not uint8_t.
Even though they're technically the same typedef'ed type (I'd keep
style consistent according to the argument rdivacky is making). I
guess this has about the same bikeshed-ability as my proposal to
change all of the *chflags syscalls to use fflags_t instead of
u_long/int/etc on freebsd-fs did a few weeks back.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinfg1GCsk5w%2BZTvqcuE0021ox%2ByQoKiTti5c0YL>