From owner-freebsd-current@freebsd.org Wed Jun 19 19:20:07 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C4F715C73A4 for ; Wed, 19 Jun 2019 19:20:07 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC7F17683F; Wed, 19 Jun 2019 19:20:06 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 3D4C912346; Wed, 19 Jun 2019 19:20:06 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 3D1A31A13; Wed, 19 Jun 2019 19:20:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id E6C-i_zzlUFG; Wed, 19 Jun 2019 19:20:01 +0000 (UTC) Subject: Re: r349100: buildworld does not compile (ld: error: duplicate symbol: sse42_crc32c) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 053811A0A From: Bryan Drewery To: Rainer Hurling Cc: FreeBSD Current References: <35afacf4-a52b-2b82-144c-4d40cbe58d74@FreeBSD.org> Openpgp: preference=signencrypt Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAG0JEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBPkXPLLDqup6XIofCTXXcbtuRpfPBQJb5hLu BQkNPvODAAoJEDXXcbtuRpfP9rMH/3f7cfX5rzyEV5QNfV/wS4jFukLoPZ4+nCM/TKxH3pEX 2bLbeQbkk6La8cueQ5Lpoht5XFZ18Y5TbMittngltrlNzoDD0h9are24OkDFGim3afJU7tkj IGQa1if+re+vI5BhzYwRhj0oKXzBi39M5oePd3L1dXfx83rg2FPyZBdIejsz6fR74T3JVkbd 6k2l5/3Zk2uiNMy+eBfDRgYE1E6CP28kV0nCeGKZgSVso0kGUUHud7voKqGVpMvbd0mE4pp4 PE5YJaFPjrll9miaDAvdU8LGIq5n6+aXPLKoQ/QNl6mg6ifgI6FfKILOkTizLW8E5PBSNnCm NapQ55yjm125AQ0EUmmGawEIAKJUU9+Q19oW1RK5jTf3m56j+szIc8Y9DaLC8REUKl4UZJBK BqCl6c0cukVApOD92XoU6hJPm2rLEyp/IcYcPPNTnVu8D8h9oag2L8EiFN7+2hk0xG+lwjc8 uOIZycme7AIJsBU4AZ1v63lxm2k104hwpiatgbe71GIGl7p1MX6ousP/wGzXCOF25Dx9w02C eRe7zEMfhnFjSUhzdCC9han2+KaVB7qIqNR3b8NfbwRNlwPmHqlhXffUow9OsQjSnTK8WKNR lx7xzVccXIvWP2wECFrmqmzMmXpSrmIuiWEpFwZ9x2a0Pva8dCNRiCVTK51IlRXKjaAxiN1u IUrMm6UAEQEAAYkBJQQYAQoADwUCUmmGawIbDAUJCWYBgAAKCRA113G7bkaXz1Q+CADaYZCn bzIJQqwnoocVXL+Wkd+hCsoX6zsd8pNTY5tV5U1fgjxl1bVQ7jyZGrEQ7BjyvlhIfpfTo6aK oJfZpIxeDc3Tr+X7O2UHT5QYaWRcGO+X3+eKL5sLpvxda67RftClv2hgEr1i2hqjK5WmUCaN 2P9w+i7rmZ4ohpLXINOMeHjnQOtbxCCF7qXRsVfgEcpNKb31T3QwvsRjX0HqIjYFlKpa61Wz IPvWgBERjo0aAOkI4g7oVLjX5Z5gINGPy+xr8GJqhfZ3ZIEOwLCwTB71+Dk9gyLa5UiG8vo6 vGfA50H5OSC87LnNlI07b1Qb8mKVkqg13PbCkRpTMKEYaou9iQElBBgBCgAPAhsMBQJa6M4o BQkKYHs9AAoJEDXXcbtuRpfPpuQH/0d1RHcTTAHAyHrPQA4UMqH49tEj1d3gidx2ETnm00rj XTrnRreAAMgPCrPeLvYYiKeSBrHOkQ7E/Vuztr4F4Xenld3omOTon+cSyGKyA1btWNRskcUa zxJ/0DqgzerhWQj8CtWjmqRnGAqzvZQdIDLk1X4B2p1Ota4AvbTF9DqADskXfld/zPJQzYYy XRfyKTt0nWMyn5MHbsuKmpsOBqYXMf0X2EL2C6v3g5D/HedD6YVnW6KlgcDUR2sq6Fv9Ozhs 38TOXyeZgbFz0HDtkHEY5Mh3+sQjOh4takC+Dp1zDRP2U19JZzo9f6R/d05c0h2TD02oogPz AQ97xrFwZgaJATwEGAEKACYCGwwWIQT5Fzyyw6rqelyKHwk113G7bkaXzwUCW+YS+AUJDT7z jQAKCRA113G7bkaXzwo3B/4rwbDqXaXm6YC4s0jVOf1+MljeQIsbHPVQZ0IRigCpzCDSUFTK QOebA9iUj8JaF2DPwd6sjyUUv/XMCLl+SwzSijmVN0Kfk85XspzNef8XmteKK1mERkYnLWBw TNwp6qezg/CukNbobNH08ciT+z2fxtPuwqK5X9Q5R4Q7egth5XUTxbwLwIJerEfVs4HG+687 m9h1bWyYJemB24MgBu8fTaVxas8dSSwDHabdgyGMKIvqDHUUJQSMDbio0Iwhs7lx2p3Xd5Br wQLMiaUPnKBHqfVM8ADWldvHF6xa9keBUjnEedKwQNjYf76lGH6bLwbyZcLigKFdXY1R2ooT Xi+R Organization: FreeBSD Message-ID: <6a5f0886-3ee8-df4d-0cb4-65a3e89bc4a0@FreeBSD.org> Date: Wed, 19 Jun 2019 12:20:00 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <35afacf4-a52b-2b82-144c-4d40cbe58d74@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vbKdDPlhdI0VQuJzZeZQje0zuv624BTto" X-Rspamd-Queue-Id: AC7F17683F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 19:20:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vbKdDPlhdI0VQuJzZeZQje0zuv624BTto Content-Type: multipart/mixed; boundary="GCqtYhtI7uyqlo8pa7Pnps0wwrkjtOHAj"; protected-headers="v1" From: Bryan Drewery To: Rainer Hurling Cc: FreeBSD Current Message-ID: <6a5f0886-3ee8-df4d-0cb4-65a3e89bc4a0@FreeBSD.org> Subject: Re: r349100: buildworld does not compile (ld: error: duplicate symbol: sse42_crc32c) References: <35afacf4-a52b-2b82-144c-4d40cbe58d74@FreeBSD.org> In-Reply-To: <35afacf4-a52b-2b82-144c-4d40cbe58d74@FreeBSD.org> --GCqtYhtI7uyqlo8pa7Pnps0wwrkjtOHAj Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/19/19 11:05 AM, Bryan Drewery wrote: > On 6/19/19 11:02 AM, Bryan Drewery wrote: >> On 6/16/19 9:33 AM, Warner Losh wrote: >>> On Sun, Jun 16, 2019, 9:51 AM Rainer Hurling wrote:= >>> >>>> If I try to build world almost recent sources (r349100) on HEAD amd6= 4 >>>> (r348775), it stops with the following error: >>>> >>>> >>>> [..snip..] >>>> (cd /usr/src/tests/sys/kern && DEPENDFILE=3D.depend.libkern_crc32 >>>> NO_SUBDIR=3D1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PR= OGS=3Dt >>>> PROG=3Dlibkern_crc32 ) >>>> echo libkern_crc32: /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libc.a >>>> /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libprivateatf-c.a >> >>>> .depend.libkern_crc32 >>>> cc -target x86_64-unknown-freebsd13.0 >>>> --sysroot=3D/usr/obj/usr/src/amd64.amd64/tmp >>>> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe >>>> -DUSERSPACE_TESTING -MD -MF.depend.libkern_crc32.libkern_crc32.o >>>> -MTlibkern_crc32.o -std=3Dgnu99 -fstack-protector-strong -Wsystem-he= aders >>>> -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter >>>> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith >>>> -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body >>>> -Wno-string-plus-int -Wno-unused-const-variable >>>> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equalit= y >>>> -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef >>>> -Wno-address-of-packed-member -Qunused-arguments -c >>>> /usr/src/tests/sys/kern/libkern_crc32.c -o libkern_crc32.o >>>> cc -target x86_64-unknown-freebsd13.0 >>>> --sysroot=3D/usr/obj/usr/src/amd64.amd64/tmp >>>> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -DUSERSPACE_TES= TING >>>> -std=3Dgnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall= >>>> -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes >>>> -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized >>>> -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int >>>> -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-val= ue >>>> -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion >>>> -Wno-unused-local-typedef -Wno-address-of-packed-member >>>> -Qunused-arguments -DUSERSPACE_TESTING -o libkern_crc32 >>>> libkern_crc32.o /usr/src/sys/libkern/x86/crc32_sse42.c -lprivateatf= -c >>>> /usr/src/sys/libkern/x86/crc32_sse42.c -lprivateatf-c >>>> ld: error: duplicate symbol: sse42_crc32c >>>>>>> defined at crc32_sse42.c >>>>>>> /tmp/crc32_sse42-2988bd.o:(sse42_crc32c) >>>>>>> defined at crc32_sse42.c >>>>>>> /tmp/crc32_sse42-bcf3d2.o:(.text+0x3C0) >>>> cc: error: linker command failed with exit code 1 (use -v to see >>>> invocation) >>>> *** [libkern_crc32] Error code 1 >>>> make[6]: stopped in /usr/src/tests/sys/kern >>>> 1 error >>>> make[6]: stopped in /usr/src/tests/sys/kern >>>> *** [libkern_crc32] Error code 2 >>>> >>>> >>>> This happens with two older cpus, Intel (Core 17-4770) and AMD (Phen= om >>>> II X6 1090T). >>>> >>>> Am I the only one, who observes this breakage? Thanks for any hint. >>>> >>> >>> Try adding -DWITHOUT_TESTS to buildworld... >>> >>> Warner >>> >> >> ~/git/freebsd2/tests/sys/kern # env|grep TEST >> MK_TESTS=3Dno >> >> >> Doh. Turns out I've had TESTS disabled in some of my recent build test= s >> / commits. This is likely my fault. >> >=20 > Yup it is from my r349065. >=20 > It's an ambiguity between LDADD. and my newly added > LDADD.. >=20 > LDADD.libkern_crc32+=3D ${SRCTOP}/sys/libkern/x86/crc32_sse42.c >=20 > So it's added in twice. >=20 >=20 This should be fixed in r349202. Sorry for the trouble. --=20 Regards, Bryan Drewery --GCqtYhtI7uyqlo8pa7Pnps0wwrkjtOHAj-- --vbKdDPlhdI0VQuJzZeZQje0zuv624BTto Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl0KiuAACgkQNddxu25G l8/yswf+Jo6C+utjGlpSdJVRceL1TugnsogvpKhjhN/vzZijZEU7uUP5x3n3qm7p 0uiNFhoWTpov1eirBKzw36Fy+XGmELm3sLNQrQmREtkbGl4DVhyUMFfc042XoFMj bN3iItMvGFftzOwSJriqF9SCs+RPwcPF+hnJFkKW3ttUHuVWwW1mapvZ4BtmyqyK 37jWCwZrmEFIknErQqMebF/mVOQt1pa3PD7kDToY32smpiqufHAB/LlpjnP8zPNR l+Sth2eh4IZgMXC2SUo3hCan7zeumlqpkJz9jF1PargB2QSPKbZ1bA5qcqrpK2eS gnI8ed9xiQoBgW436as9/wY6vOTYnw== =B03z -----END PGP SIGNATURE----- --vbKdDPlhdI0VQuJzZeZQje0zuv624BTto--