From owner-svn-src-all@FreeBSD.ORG Mon Aug 4 17:24:47 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BDF7F6C1; Mon, 4 Aug 2014 17:24:47 +0000 (UTC) Received: from mail-pd0-x231.google.com (mail-pd0-x231.google.com [IPv6:2607:f8b0:400e:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E14E2FC3; Mon, 4 Aug 2014 17:24:47 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id p10so9990047pdj.36 for ; Mon, 04 Aug 2014 10:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=nCMg5ZZpAb9KnUWcYaaYHKPT6Ay8NIam0ivtTUBKgwo=; b=GOKF43wJstschhwbqsyrjeIKAvY2E18rgBO4OhpznAHyp9K3lg+MG7x/UYNLhrO/So uRB00uKrtnUbLTqcpdup3X8Q8oUnOC2GS1kp/2yogzdqZ3qou/KLOnqHwI7Mlaj0ZiNW UQ1NSleZEE/XKphlHpu5V4dwjWXAc57UQusJv3pQ5sHx6Qwg6K0nzImPbjuHV2pxfXKO pjpYd9oti5E7WoeiISY6GIGqeuB+Sz/K2p9JERI0UM+LCoMxDUjwbI/0MenFqbwkyKGh 5WEHHIP8PqDGFt8Fq0tK87qNv03y82k+H1abWBkH1OohvKr+P3haJsqmXvlnuIlMPmen 0kxg== X-Received: by 10.68.113.133 with SMTP id iy5mr3814632pbb.135.1407173087139; Mon, 04 Aug 2014 10:24:47 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:e49e:2d44:7164:e687? ([2601:8:ab80:7d6:e49e:2d44:7164:e687]) by mx.google.com with ESMTPSA id np15sm8478890pdb.84.2014.08.04.10.24.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Aug 2014 10:24:46 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_0E4569D0-C2C9-4728-9A28-BE74818402F9"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target From: Garrett Cooper In-Reply-To: <20140804185707.P7764@besplex.bde.org> Date: Mon, 4 Aug 2014 10:24:44 -0700 Message-Id: References: <53df1ed9.5830.34b38bca@svn.freebsd.org> <20140804185707.P7764@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2014 17:24:47 -0000 --Apple-Mail=_0E4569D0-C2C9-4728-9A28-BE74818402F9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Hi Bruce! On Aug 4, 2014, at 2:23 AM, Bruce Evans wrote: > On Mon, 4 Aug 2014, Garrett Cooper wrote: ... > I hope this fixes the error found by "make checkdpadd". -L is too = hard > for the current "make checkdpadd" to handle. Old aout versions worked > better using linker support. They also found the correct dependencies > (on shared libraries for shared linkage, not the pseudo-dependenci on > the hard-coded static librar for shared linkage). Thank you for the reminder about that make target :). > "make checkdpadd" currently finds broken 143 makefiles with = inconsistent > DPADD. 62 of them are for clang. Most of these misuse DPADD for > headers. The next largest source of errors is libtermcapw. = LIBTERMCAPW > is missing in bsd.libnames.mk. This breaks about 29 makefiles where > LIBTERMCAP was blindly replaced by LIBTERMCAPW. bsd.libnames.mk and > DPADD were unnecessary with the old aout versions. I=92ll file bugs for any issues I find and work with maintainers to fix = the issues. I=92m not sure if you=92re on Phabricator, but I=92d be = happy to add you to the reviews if you would like. Thanks! -Garrett --Apple-Mail=_0E4569D0-C2C9-4728-9A28-BE74818402F9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJT38HcAAoJEMZr5QU6S73eUtYIAJe0JVH2/KnnyuJTHzExxiY9 TlPUYYO22XTW7JWw3tBy8SU8KnU403+5slffJdHYg3WWHh2/DMWCNQs5Rs0Vhobl hWrTTEmOr5Rz6T2wRqiFb7iwra/kMF1Qb4s7DEYxycHFwApCNv0ROhWO+rpD/Bac 9JOo+cMjs8u8lSVpjLtJ5cknzl7opH/WkcFGC7xSIfKOBHYg2owH8K381J+2FMhM 3EK+XYQpI5AM9NcGlwYokU0yFThx4ugWXewR92nU3rl9ABNd0W76K0wXM0Mo4Iuz RqsTtDPmieyb9VFPGeWswNsWKCbdDYU7cijN7llhQ3uDREVPZrUFtICsyUx6yOE= =BwSf -----END PGP SIGNATURE----- --Apple-Mail=_0E4569D0-C2C9-4728-9A28-BE74818402F9--