From owner-cvs-src@FreeBSD.ORG Tue Nov 30 20:36:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 628D416A4CF; Tue, 30 Nov 2004 20:36:50 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63B5E43D5A; Tue, 30 Nov 2004 20:36:49 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAUKajal089574; Tue, 30 Nov 2004 22:36:45 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 19807-05; Tue, 30 Nov 2004 22:36:44 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iAUKaiiX089570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Nov 2004 22:36:44 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iAUKaiMi029987; Tue, 30 Nov 2004 22:36:44 +0200 (EET) (envelope-from ru) Date: Tue, 30 Nov 2004 22:36:43 +0200 From: Ruslan Ermilov To: Poul-Henning Kamp Message-ID: <20041130203643.GB20833@ip.net.ua> References: <20041130192316.GB3845@ip.net.ua> <54142.1101843659@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm" Content-Disposition: inline In-Reply-To: <54142.1101843659@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: Doug Barton cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2004 20:36:50 -0000 --V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 30, 2004 at 08:40:59PM +0100, Poul-Henning Kamp wrote: > In message <20041130192316.GB3845@ip.net.ua>, Ruslan Ermilov writes: >=20 > >> The reason I did not remove MNT_NODEV but only #defined it to zero was > >> to make it silently ignored. > >>=20 > >To make it silently ignored, you should have left it with its old value. > >Most operations with MNT_* constants are "bitwise AND", and so zero was > >not a good choice. >=20 > I tried to find my copy of "Bitmaps for dummies" to check what > you're saying but I can't find it right now, still, I'm very sure > that you are wrong, I just don't have the book to prove it. >=20 > Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK. >=20 Well, definitely *not* in sbin/mount/mount.c. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --V0207lvV8h4k8FAm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBrNnbqRfpzJluFF4RAoebAJ9VxWIh89i+MguDFxVxXec4UcWsiwCfRiHW qWzXVLtJq7ULu8fnUQ+zalc= =PDuS -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm--