From owner-freebsd-current@FreeBSD.ORG Tue Sep 27 04:00:27 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AF351065675; Tue, 27 Sep 2011 04:00:27 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 552418FC08; Tue, 27 Sep 2011 04:00:25 +0000 (UTC) Received: by bkbzs8 with SMTP id zs8so7865166bkb.13 for ; Mon, 26 Sep 2011 21:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ap2t8l3hSFORTgm33qiMl5nt8CvDgCrHyhDTnY1a1cA=; b=Oc38Mg0PnsvxsLPubLDsiw4f9dJpOIxFiH4HaDVQ0xhT7T/nWSEjpLk31BGFH8/Qk2 r5mVSToXOInw23O5xa6KtMmpsCrPBDTxDTfpbSMVhrVQtzD7hGjJo3zwgKtrq4grX7m+ 0JmjIMcHreXWUVUBZj4KvYPQIYtpbG3qT8uyc= MIME-Version: 1.0 Received: by 10.204.133.92 with SMTP id e28mr4505093bkt.407.1317096025145; Mon, 26 Sep 2011 21:00:25 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.204.140.24 with HTTP; Mon, 26 Sep 2011 21:00:25 -0700 (PDT) In-Reply-To: References: <201109262324.p8QNO0NN070853@freefall.freebsd.org> <4E811FF7.7010607@a1poweruser.com> <4E8126D3.5020407@FreeBSD.org> <4E812DB7.3000302@FreeBSD.org> Date: Mon, 26 Sep 2011 21:00:25 -0700 X-Google-Sender-Auth: 6XxY3zwRJu_P1DsyqhB8L6RD_pI Message-ID: From: Craig Rodrigues To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , eadler@freebsd.org, FreeBSD Questions , Fbsd8 , freebsd-current@freebsd.org Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2011 04:00:27 -0000 On Mon, Sep 26, 2011 at 8:30 PM, Garrett Cooper wrote: > > ... > > =A0 =A0 =A0 =A0Please fix it and move on. > Thanks, > -Garrett > > $ usr.sbin/burncd/burncd -f /dev/cd0 blank > burncd: device provided not an acd(4) device: /dev/cd0. > > Please verify that your kernel is built with acd(4) and the beforemention= ed > device is supported by acd(4). Hi, That patch is an improvement over the existing behavior. However, we may want to go a bit farther. Here are some possible scenarios: (1) User has a system with ATAPI CD-ROM only. (2) User has a system with ATAPI CD-ROM *and* USB CD-ROM. (3) User has a system with USB CD-ROM only. (4) User has a system with ATAPI CD-ROM and SCSI CD-ROM (5) User has a system with SCSI CD-ROM only I would guess that (1) is the most common scenario, and end-users will definitely encounter it and complain. In the case of (1), it would be nice if we could fail if we try to burn to /dev/cd0, as per your patch, but still check to see if ATA_CAM is enabled in the kernel, and print out a message with pointers for using cdrtools. With your patch, a user will see a message about acd(4), and try to get it to compile/kldload/whatever acd(4) on their system, and then not get it to work because ATA_CAM is enab= led. Adding notes to the burncd man page that burncd will not work on ATAPI devices if ATA_CAM is enabled would be good to do also. If the long term plan is to get rid of the old ATA subsystem, and completely move to ATA_CAM, then we should put a deprecation warning in the burncd man page as well, to give users a further heads-up. --=20 Craig Rodrigues rodrigc@crodrigues.org