Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Sep 2010 11:04:39 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Rob Farmer <rfarmer@predatorlabs.net>
Cc:        freebsd-fs@freebsd.org, freebsd-current@freebsd.org
Subject:   Re: ZFS v28 is ready for wider testing.
Message-ID:  <20100902090439.GB29617@garage.freebsd.pl>
In-Reply-To: <AANLkTim=Tiwo115ML07yJarOjKA%2BMr-4uYwpV-m6xxi6@mail.gmail.com>
References:  <20100831215915.GE1932@garage.freebsd.pl> <AANLkTim=Tiwo115ML07yJarOjKA%2BMr-4uYwpV-m6xxi6@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--ZmUaFz6apKcXQszQ
Content-Type: multipart/mixed; boundary="hHWLQfXTYDoKhP50"
Content-Disposition: inline


--hHWLQfXTYDoKhP50
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 02, 2010 at 01:55:51AM -0700, Rob Farmer wrote:
> On Tue, Aug 31, 2010 at 2:59 PM, Pawel Jakub Dawidek <pjd@freebsd.org> wr=
ote:
> >
> > Ok, now that I know you read everything carefully, here is the patch:
> >
> > =A0 =A0 =A0 =A0http://people.freebsd.org/~pjd/patches/zfs_20100831.patc=
h.bz2
> >
>=20
> buildworld on i386 (yes I know ZFS isn't ideal there):
[...]

Yes, I know about this problem, You can use attached patch or wait for
full patch, which I'll be sending later today.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--hHWLQfXTYDoKhP50
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="atomic.h.patch"
Content-Transfer-Encoding: quoted-printable

--- sys/cddl/compat/opensolaris/sys/atomic.h
+++ sys/cddl/compat/opensolaris/sys/atomic.h
@@ -39,10 +39,9 @@
 #ifndef __LP64__
 extern void atomic_add_64(volatile uint64_t *target, int64_t delta);
 extern void atomic_dec_64(volatile uint64_t *target);
-extern void *atomic_cas_ptr(volatile void *target, void *cmp,  void *newva=
l);
 #endif
 #ifndef __sparc64__
-extern uint64_t atomic_cas_32(volatile uint32_t *target, uint32_t cmp,
+extern uint32_t atomic_cas_32(volatile uint32_t *target, uint32_t cmp,
     uint32_t newval);
 extern uint64_t atomic_cas_64(volatile uint64_t *target, uint64_t cmp,
     uint64_t newval);
@@ -119,21 +118,19 @@
 }
=20
 #ifndef COMPAT_32BIT
-#if defined(__LP64__)
+#ifdef __LP64__
 static __inline void *
 atomic_cas_ptr(volatile void *target, void *cmp,  void *newval)
 {
-	return ((void *)atomic_cas_64((volatile uint64_t *)target, (uint64_t)cmp,
-	    (uint64_t)newval));
+	return ((void *)atomic_cas_64(target, (uint64_t)cmp, (uint64_t)newval));
 }
 #else
 static __inline void *
 atomic_cas_ptr(volatile void *target, void *cmp,  void *newval)
 {
-	return ((void *)atomic_cas_32((volatile uint64_t *)target, (uint64_t)cmp,
-	    (uint64_t)newval));
+	return ((void *)atomic_cas_32(target, (uint32_t)cmp, (uint32_t)newval));
 }
 #endif
-#endif
+#endif	/* !COMPAT_32BIT */
=20
 #endif	/* !_OPENSOLARIS_SYS_ATOMIC_H_ */

--hHWLQfXTYDoKhP50--

--ZmUaFz6apKcXQszQ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEARECAAYFAkx/aKcACgkQForvXbEpPzR1NgCfSnScNjJXmF4glzhV0HLFSajN
FikAoMjsbxt5Qp1xSu32PvK+4N5gOeGY
=BeVA
-----END PGP SIGNATURE-----

--ZmUaFz6apKcXQszQ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100902090439.GB29617>