From nobody Thu Nov 9 19:32:50 2023
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SRBtp4DwDz5085c;
Thu, 9 Nov 2023 19:32:50 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4SRBtp3k7Xz3NBC;
Thu, 9 Nov 2023 19:32:50 +0000 (UTC)
(envelope-from git@FreeBSD.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
t=1699558370;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=TXvr+PL/PgBUznlN9daoNIt83xTXlP+y93RYHeZRwh8=;
b=EobV8yZw2w8yJhFSdO1mrx3p7YfTq5+tFBHXJ0ywVGE9ktu8NrCWcgexJy66DUFPdDoqyZ
Tnnjssf9vR9hCKDeYnhqjogWFykwycYb6MtEKq37tqhV/OXCpuRlpi9jmzKgLtmQrpFTGo
cBkwBBUrY9R1sh/DpxS2gUOW+qofwKAYnRkMg+1PctlNFVCRMwQpV9CvkDmDQ1h42fTwT5
ypbSU4FKzHfsdidji2MfxnaF19MsZfMF/OB3gqQ4G/o67fC4s8tSYb7tm4F6cExPCKkUyk
YxcCfpTgnKWY/Xr+XNutNHjhp+iUrY8fVyx8rz5ARos5KhxIViwHTI4B68miog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
s=dkim; t=1699558370;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=TXvr+PL/PgBUznlN9daoNIt83xTXlP+y93RYHeZRwh8=;
b=Jpcv4fyU0De9YS+OgXpGDJdMUbIutPw6pt7Uu80QKaoG48N718ONYDmX4oj/+/wz04Xmy6
FcZOVHTjHTFGuOYE9hNmyKIUtfq8VfT5TUOgIAeXuG3ZP98YILHF6QxyX8gMaMynAuwAa6
Iy0BaqvldKEA2rM+NWr088evImkK9irFWVqxvxGX8upXz55if9BwJzCRNZIO7K8vadKS1s
QtwYF8Yx4QbFL1D9Lv+slhDfcYPU9Fp2BfZBM7mPLHXlJLH6Tb/N7Jw1Q3oBuygiMs6+dx
3bCosByc+sJLJIsZSRLpZSjCH/3GazqL4OisD8HoK9HY+nbcSo1NlKkAjhPotQ==
ARC-Authentication-Results: i=1;
mx1.freebsd.org;
none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699558370; a=rsa-sha256; cv=none;
b=GBHEX7qgCxteUPOHHkIwCygU50IKEuDhvCHHEGNqE4zvIfVy4m8XBgCgZNT116mG0ch9s4
F8tWLisUHuXRry/V5p1rwUNd+YE+vPxMt3zDRz3X7nKioVdr3maOKuGogqlB+T98CeHIzI
Qa7J6YdV/sUu5TyZvSRfJmgMKmGMyVZ8p9D/dR3xuTETyEyQfWV8i6ZdiBjs4LgfiBAPKo
wubVV4+SeVJrIzJzw+UZdiqaUN+CDXzI1xDma6zNr0xPd5FaiQe8i0bZX4jaOYuK80mk8P
ISLqjCE8p1QS8oYaeQaq7SpwVMY/qe+8F6cuRtqdVmrTZ8ryDDUdczdGHvaGUQ==
Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SRBtp2k8bzCpf;
Thu, 9 Nov 2023 19:32:50 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from gitrepo.freebsd.org ([127.0.1.44])
by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3A9JWovm065919;
Thu, 9 Nov 2023 19:32:50 GMT
(envelope-from git@gitrepo.freebsd.org)
Received: (from git@localhost)
by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3A9JWocO065916;
Thu, 9 Nov 2023 19:32:50 GMT
(envelope-from git)
Date: Thu, 9 Nov 2023 19:32:50 GMT
Message-Id: <202311091932.3A9JWocO065916@gitrepo.freebsd.org>
To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
dev-commits-ports-main@FreeBSD.org
From: Dimitry Andric <dim@FreeBSD.org>
Subject: git: ff46b0fb8d1d - main - x11-toolkits/wxgtk30: fix build
with lld 17
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Git-Committer: dim
X-Git-Repository: ports
X-Git-Refname: refs/heads/main
X-Git-Reftype: branch
X-Git-Commit: ff46b0fb8d1d41ebdec82818d6d12327edb5374b
Auto-Submitted: auto-generated
The branch main has been updated by dim:
URL: https://cgit.FreeBSD.org/ports/commit/?id=ff46b0fb8d1d41ebdec82818d6d12327edb5374b
commit ff46b0fb8d1d41ebdec82818d6d12327edb5374b
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-11-09 19:24:08 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-11-09 19:31:58 +0000
x11-toolkits/wxgtk30: fix build with lld 17
Building x11-toolkits/wxgtk30 with lld 17 results in the following link
errors:
ld: error: version script assignment of 'WXU_3.0.5' to symbol 'wxSVGFileDCImpl::DoDrawPolyPolygon(int, int const*, wxPoint const*, int, int, wxPolygonFillMode)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.5' to symbol 'wxSVGFileDCImpl::SetAxisOrientation(bool, bool)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.5' to symbol 'wxSVGFileDCImpl::SetDeviceOrigin(int, int)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.5' to symbol 'wxSVGFileDCImpl::SetLogicalOrigin(int, int)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.5' to symbol 'wxWindow::GetContentScaleFactor() const' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.4' to symbol 'wxDirButton::DoApplyWidgetStyle(_GtkRcStyle*)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.4' to symbol 'wxFileButton::DoApplyWidgetStyle(_GtkRcStyle*)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.4' to symbol 'wxRibbonPage::ShowScrollButtons1()' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.4' to symbol 'wxWindow::GTKApplyCssStyle(char const*)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.3' to symbol 'wxDataViewRenderer::FinishEditing()' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.3' to symbol 'wxFloatProperty::DoGetAttribute(wxString const&) const' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.2' to symbol 'wxGenericListCtrl::EndEditLabel(bool)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.1' to symbol 'wxDataViewListCtrl::ClearColumns()' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.1' to symbol 'wxDataViewListStore::ClearColumns()' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.1' to symbol 'wxInfoBarGeneric::SetForegroundColour(wxColour const&)' failed: symbol not defined
ld: error: version script assignment of 'WXU_3.0.1' to symbol 'wxTDIChildFrame::DoMoveWindow(int, int, int, int)' failed: symbol not defined
Add -Wl,--undefined-version to LDFLAGS to suppress these errors, since
wxWidgets reuses the same linker version script for all its shared
libraries.
PR: 273753
Approved by: blanket (desktop)
MFH: 2023Q4
---
x11-toolkits/wxgtk30/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/x11-toolkits/wxgtk30/Makefile b/x11-toolkits/wxgtk30/Makefile
index f75b0a1116c6..ebe1594f3670 100644
--- a/x11-toolkits/wxgtk30/Makefile
+++ b/x11-toolkits/wxgtk30/Makefile
@@ -102,6 +102,11 @@ CONFIGURE_ARGS+=--disable-tls
CONFIGURE_ARGS+=--disable-precomp-headers
.endif
+# wxWidgets uses the same linker version script for all its shared libraries, so
+# some symbols are expectedly undefined. Suppress errors with lld >= 17 due to
+# these undefined symbols.
+LDFLAGS+= -Wl,--undefined-version
+
post-build-NLS-on:
@${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale