From owner-svn-src-all@freebsd.org Mon Jan 14 23:24:00 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8ECDE148AB37; Mon, 14 Jan 2019 23:24:00 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [198.45.61.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E3F6382442; Mon, 14 Jan 2019 23:23:59 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x0ENNpf2043618 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 14 Jan 2019 15:23:51 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x0ENNpQR043617; Mon, 14 Jan 2019 15:23:51 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Mon, 14 Jan 2019 15:23:51 -0800 From: Gleb Smirnoff To: "Jason A. Harmening" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343005 - head/sys/kern Message-ID: <20190114232351.GS18452@FreeBSD.org> References: <201901132033.x0DKXtin020499@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201901132033.x0DKXtin020499@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: E3F6382442 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.939,0]; ASN(0.00)[asn:2906, ipnet:198.45.48.0/20, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 23:24:00 -0000 Jason, thanks a lot for fixing this. On Sun, Jan 13, 2019 at 08:33:55PM +0000, Jason A. Harmening wrote: J> Author: jah J> Date: Sun Jan 13 20:33:54 2019 J> New Revision: 343005 J> URL: https://svnweb.freebsd.org/changeset/base/343005 J> J> Log: J> Handle SIGIO for listening sockets J> J> r319722 separated struct socket and parts of the socket I/O path into J> listening-socket-specific and dataflow-socket-specific pieces. Listening J> socket connection notifications are now handled by solisten_wakeup() instead J> of sowakeup(), but solisten_wakeup() does not currently post SIGIO to the J> owning process. J> J> PR: 234258 J> Reported by: Kenneth Adelman J> MFC after: 1 week J> Differential Revision: https://reviews.freebsd.org/D18664 J> J> Modified: J> head/sys/kern/uipc_socket.c J> J> Modified: head/sys/kern/uipc_socket.c J> ============================================================================== J> --- head/sys/kern/uipc_socket.c Sun Jan 13 19:49:46 2019 (r343004) J> +++ head/sys/kern/uipc_socket.c Sun Jan 13 20:33:54 2019 (r343005) J> @@ -886,6 +886,8 @@ solisten_wakeup(struct socket *sol) J> } J> SOLISTEN_UNLOCK(sol); J> wakeup_one(&sol->sol_comp); J> + if ((sol->so_state & SS_ASYNC) && sol->so_sigio != NULL) J> + pgsigio(&sol->so_sigio, SIGIO, 0); J> } J> J> /* J> -- Gleb Smirnoff