Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jan 2012 22:31:37 -0500
From:      Sahil Tandon <sahil+cvs-ports@tandon.net>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Yen-Ming Lee <leeym@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/chinese/tin Makefile ports/chinese/tin/files patch-attrib.c patch-cook.c patch-init.c patch-mail.c patch-tin.defaults patch-tin_defaults
Message-ID:  <20120104033137.GB3565@magic.hamla.org>
In-Reply-To: <20120103155438.GA70361@FreeBSD.org>
References:  <201201021534.q02FYLba029039@repoman.freebsd.org> <20120103155438.GA70361@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2012-01-03 at 15:54:38 +0000, Alexey Dokuchaev wrote:

> ...
> >   Revision  Changes    Path
> >   1.1       +11 -0     ports/chinese/tin/files/patch-tin.defaults (new)
> >   1.2       +0 -11     ports/chinese/tin/files/patch-tin_defaults (dead)
>
> This renaming of the patch file just because someone thought that dot
> looks better than underscore is gratuitous and should not have been
> done.  (Not to mention that things that this patch tries to accomplish
> are usually done with one simple REINPLACE_CMD line.)

I suspect the motivation for the change was to canonicalize the filename
as described in the PH.  But to do that correctly, I believe the
filename should be be: patch-doc-tin.defaults. :)  Anyway, as you noted,
such simple replacements belong in the Makefile.

-- 
Sahil Tandon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120104033137.GB3565>