From owner-cvs-all@FreeBSD.ORG  Wed Jan  4 03:31:42 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24332106566B;
	Wed,  4 Jan 2012 03:31:42 +0000 (UTC)
	(envelope-from sahil@tandon.net)
Received: from cricket.hamla.org (cricket.hamla.org [206.251.255.31])
	by mx1.freebsd.org (Postfix) with ESMTP id F412C8FC14;
	Wed,  4 Jan 2012 03:31:41 +0000 (UTC)
Received: from magic.hamla.org (cpe-68-174-92-20.nyc.res.rr.com [68.174.92.20])
	by cricket.hamla.org (Postfix) with ESMTPSA id A2BA18A01D;
	Tue,  3 Jan 2012 22:31:40 -0500 (EST)
Date: Tue, 3 Jan 2012 22:31:37 -0500
From: Sahil Tandon <sahil+cvs-ports@tandon.net>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Message-ID: <20120104033137.GB3565@magic.hamla.org>
References: <201201021534.q02FYLba029039@repoman.freebsd.org>
	<20120103155438.GA70361@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120103155438.GA70361@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Virus-Scanned: clamav-milter 0.97.3 at cricket.hamla.org
X-Virus-Status: Clean
Cc: cvs-ports@FreeBSD.org, Yen-Ming Lee <leeym@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/chinese/tin Makefile ports/chinese/tin/files
 patch-attrib.c patch-cook.c patch-init.c patch-mail.c
 patch-tin.defaults patch-tin_defaults
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: cvs-ports@FreeBSD.org
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2012 03:31:42 -0000

On Tue, 2012-01-03 at 15:54:38 +0000, Alexey Dokuchaev wrote:

> ...
> >   Revision  Changes    Path
> >   1.1       +11 -0     ports/chinese/tin/files/patch-tin.defaults (new)
> >   1.2       +0 -11     ports/chinese/tin/files/patch-tin_defaults (dead)
>
> This renaming of the patch file just because someone thought that dot
> looks better than underscore is gratuitous and should not have been
> done.  (Not to mention that things that this patch tries to accomplish
> are usually done with one simple REINPLACE_CMD line.)

I suspect the motivation for the change was to canonicalize the filename
as described in the PH.  But to do that correctly, I believe the
filename should be be: patch-doc-tin.defaults. :)  Anyway, as you noted,
such simple replacements belong in the Makefile.

-- 
Sahil Tandon