From owner-freebsd-ports@FreeBSD.ORG Wed Aug 13 17:13:56 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88629A5A for ; Wed, 13 Aug 2014 17:13:56 +0000 (UTC) Received: from mail-oa0-x229.google.com (mail-oa0-x229.google.com [IPv6:2607:f8b0:4003:c02::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48F822456 for ; Wed, 13 Aug 2014 17:13:56 +0000 (UTC) Received: by mail-oa0-f41.google.com with SMTP id j17so35817oag.28 for ; Wed, 13 Aug 2014 10:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluelife.at; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ytekC9hifx4BTj8IdTCBl5JYhO3EZk2h3dU5z/YvkMY=; b=UZmV3zRScf6tjzF5+i1JClCfIqpnyoWPQqnjOo+o+W1qfmyUHod6RZmK4Yp8zoDX1m cwxILFDtPJ6Xi1gxKyNaU8qY+px4KAVFHbQkHDNpDEdY1LKTJfDJLiH2MkGGj6RQDJBg 7R7CxDHm/XKETwPLlqLBkBONZ5FnRONfi2GBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ytekC9hifx4BTj8IdTCBl5JYhO3EZk2h3dU5z/YvkMY=; b=J1JhorZ8LH+1aJkfW1M8NbpM0EwlWaQlvsXbTUaxXWPashDIc6LOX0EHMztSn01oAd /AKE5JADmERukdXctUwQffuNApANvfKNmyRNI1+MkyY+au7d6O6RP5WeN4T73RIzxQsI tMWsWDQCCVYMNdi7JXexvhI9yrPTs6wZgutgEa4AGL1RhjDlIezF2uyNHuk8fA/qv/h9 2GAGwzgLuXTl28gQPbztPyhCP0AAUOZGVMkXqnu0roG5l2yO50pGTRwlsCYHG3Jw6tvv FjYlDAn4BjrcCJVE6GifoltFNlFf2bm7TPuW/4EE65f+qDItk2TM6L7TpsqFTB6g/N5J DMZw== X-Gm-Message-State: ALoCoQnYphyZ5aPqcs2ZtZ6V9agsJOEv438XoYEJIF6k9sR3Wefcny7oGAFNNxcWDmNtRpaLktXO MIME-Version: 1.0 X-Received: by 10.182.94.230 with SMTP id df6mr6431240obb.36.1407950035592; Wed, 13 Aug 2014 10:13:55 -0700 (PDT) Received: by 10.76.141.136 with HTTP; Wed, 13 Aug 2014 10:13:55 -0700 (PDT) X-Originating-IP: [212.95.7.150] Received: by 10.76.141.136 with HTTP; Wed, 13 Aug 2014 10:13:55 -0700 (PDT) In-Reply-To: <53EB3975.30108@gmail.com> References: <20140812205400.47242291@kalimero.tijl.coosemans.org> <53EB3975.30108@gmail.com> Date: Wed, 13 Aug 2014 19:13:55 +0200 Message-ID: Subject: Re: Redports, broken regression tests and missing check-orphans From: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= To: Vitaly Magerya Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2014 17:13:56 -0000 Am 13.08.2014 12:10 schrieb "Vitaly Magerya" : > > Bernhard, while we're at it, there are currently two problems with redports which diminish it's usefulness significantly: > > 1. Redports used to run "make regression-test" on every build; right now, each log has this instead: > > ======================================== > [: -eq: unexpected operator > === Regression tests skipped. === > ================================================================ > > So, no regression tests are executed. I don't know what the problem is here. > > 2. Most ports now have stage support; this means that checking for leftover files under ${PREFIX} is close to useless: only files in pkg-plist are copied there. Instead, leftovers should be searched for in ${STAGEDIR} -- running "make stage-qa" and "make check-orphans" with every build would do that. > > (I've already botched two patches when I assumed that successful redports run means that pkg-plist is complete). > > So, can the first problem be fixed and the second suggestion implemented? Should I be bothering tinderbox author(s) instead? I am not sure where the first issue is coming from but the second is definitely a tinderbox task. We are asking for tinderbox staging and modern leftover checks for some time already. I am working on a poudriere migration but it's quite a moving target and it requires quite a bit of work.