From owner-freebsd-hackers Fri Mar 1 10:41:48 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from ussenterprise.ufp.org (ussenterprise.ufp.org [208.185.30.210]) by hub.freebsd.org (Postfix) with ESMTP id BA1C837B402 for ; Fri, 1 Mar 2002 10:41:43 -0800 (PST) Received: (from bicknell@localhost) by ussenterprise.ufp.org (8.11.1/8.11.1) id g21IfNv05984; Fri, 1 Mar 2002 13:41:23 -0500 (EST) (envelope-from bicknell) Date: Fri, 1 Mar 2002 13:41:23 -0500 From: Leo Bicknell To: Luigi Rizzo Cc: Bob Bishop , "George V. Neville-Neil" , Doug Ambrisko , hackers@FreeBSD.ORG Subject: Re: Multicast problem with sis interface? Message-ID: <20020301184123.GA5908@ussenterprise.ufp.org> References: <200203010557.VAA1802420@meer.meer.net> <4.3.2.7.2.20020222165515.00c14850@gid.co.uk> <200203010557.VAA1802420@meer.meer.net> <4.3.2.7.2.20020301112956.00c5b550@gid.co.uk> <20020301035623.A32974@iguana.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020301035623.A32974@iguana.icir.org> Organization: United Federation of Planets Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In a message written on Fri, Mar 01, 2002 at 03:56:23AM -0800, Luigi Rizzo wrote: > ok, these three drivers behave as follows: > > "ed" pads with whatever is left in the transmit buffer from > earlier transmissions; > "vr" pads with whatever is available in the mbuf after the actual data; I point out both of these are security risks. Granted, fairly minor, but they allow someone to get all/part of a previous packet's data, when they should have it. This sort of thing has been used as an attack vector before. I think fixing these to pad with some generated (0's, 1's, /dev/random, whatever) should be a top priority. -- Leo Bicknell - bicknell@ufp.org - CCIE 3440 PGP keys at http://www.ufp.org/~bicknell/ Read TMBG List - tmbg-list-request@tmbg.org, www.tmbg.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message