From owner-cvs-src@FreeBSD.ORG Wed May 30 23:07:06 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3454E16A469; Wed, 30 May 2007 23:07:06 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id AB5F713C458; Wed, 30 May 2007 23:07:05 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.1/8.14.1) with ESMTP id l4UMutNc094849; Thu, 31 May 2007 02:56:55 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Thu, 31 May 2007 02:56:55 +0400 (MSD) From: Dmitry Morozovsky To: Gleb Smirnoff In-Reply-To: <20070528111147.GN89017@FreeBSD.org> Message-ID: <20070531025452.F79710@woozle.rinet.ru> References: <46569762.6090801@freebsd.org> <20070525090951.F53865@fledge.watson.org> <46575362.1050005@freebsd.org> <20070525.165823.29499700.imp@bsdimp.com> <20070528111147.GN89017@FreeBSD.org> X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (woozle.rinet.ru [0.0.0.0]); Thu, 31 May 2007 02:56:55 +0400 (MSD) Cc: src-committers@freebsd.org, andre@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, rwatson@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2007 23:07:06 -0000 On Mon, 28 May 2007, Gleb Smirnoff wrote: GS> On Fri, May 25, 2007 at 04:58:23PM -0600, M. Warner Losh wrote: GS> M> : during program debugging. Everything below LOG_NOTICE should not GS> M> : need fsync after each line. An examination of all users of LOG_DEBUG GS> M> : in our kernel doesn't show anything critical that would require fsync. GS> M> : The attached patch fixes syslog.conf in this regard. GS> M> GS> M> /var/log/debug.log doesn't exist by default. GS> GS> True, so the second chunk of the patch isn't necessary. GS> GS> M> Also, this patch removes GS> M> *ALL* kernel messages from /var/log/messages, which isn't right GS> M> either. GS> GS> Yes, only kern.notice messages will be logged. Andre probably GS> wants to change kern.debug to kern.info. I don't really agree GS> with this suggestion. In this case all the kern.debug messages GS> will be lost, so what is the sense in improving the debugging GS> verbosity of the kernel, if we don't log it anywhere? On most our, both production and development machines, I used to have kern.debug -/var/log/kernlog Maybe it's (tigether with the adding kernlog to newsyslog.conf with C flag) reasonable compromise? Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------