From nobody Mon Dec 4 15:21:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SkS7Q4FYHz53Sqm; Mon, 4 Dec 2023 15:21:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SkS7Q3npfz4sRD; Mon, 4 Dec 2023 15:21:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701703298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D+A5mTWPeFE5jnbPXeIfhrrmJQb4Nk0WHTgUkeUzBLY=; b=I3mWQyl7Oe7ucKtWsGSEQ5yZxxsURo9SUc43xyHN9hWF/W0Q2wgDMYMsBCqezk0pIhhdBc JA8E2ndFrVi7r5F0cv1aq37vDA5fE+DlWabUlwtqkXkDGqaBnsqmjfsRiOAucgUTbX/O3I Sq3Voh5DonPtXu5kgWPoht882itWb6bHA7xG1A9EjGmmrNjD4cqb3wnSABWxCoJpcNLpan KW9bam7YYYAnp4OGgUIs8bmu7RvY6RIFiNWy+YbF88D2qYKkCajCddqhzoOAw/hxgaQp33 QoKpO31NWeQpO0kTEqCoGuWmV49siocruy0szjllYyJAMBuRmOsx1oka1663rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701703298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D+A5mTWPeFE5jnbPXeIfhrrmJQb4Nk0WHTgUkeUzBLY=; b=Pf7uPJsAjk/q+etini7bA8MaiTVOiGpNNPWjfEpz4MfqJ/t/HA326zKY91D4lXwtK6M7zX pRQlwrsD/4zztyXA63g2vJ6mSD2lZMSA7RGZV2kHa5UUtctLqJVfRDYPjHqI4VvJL5833c KebsXcBW+bfuPKAaDTqb1695ZGgcohf3WfC1mEaPv7qlRVnSIcR1Jx4oKpF9ywDryFf/oI BT/ie8wBVcSiJxxm2uA8lxBBL8E5cyGUMMlgUQgXzWv/Znq8g9fXy7QJ+JijMvV2opd2SB cAFfrwmKXGu2NKcvTZEb9TbAvFH1S59CDocCRJayEaynMBizCf9uLw3tdkMepA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701703298; a=rsa-sha256; cv=none; b=Wl2daS+s8dts00ST4eUXx7zH3rbclfRr59fsq13OoJBecBcymLQvDok7YxvfzHtWwq7UsQ krTLH0VtW1/FxsxP1sjaG0ykYDqHEs8PQHhxgMVljOZZBYuDyEBeyXDldRJ5/uHeJpTaOL 2JrQJWMxlIxwzRai85tAcmQ65alVeG2Po+2S0OSYoSBF5O/hVF8xm4yiWDB6M8ip6jWdMy N13VcxxzHI+f2G56pN0aXLZzVupY+Nj/qbGkkHJ/R/Ps+kvNrA697ht6grB89ylXQ9D7Sc wbeJ48GXv0pqVlmVc0/iZPbbh4EpKmbo6R9f7coqD6xMRdrBAXL/wozCMzgJfw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SkS7Q2tvWzX1m; Mon, 4 Dec 2023 15:21:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3B4FLcM1087920; Mon, 4 Dec 2023 15:21:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3B4FLc8Q087917; Mon, 4 Dec 2023 15:21:38 GMT (envelope-from git) Date: Mon, 4 Dec 2023 15:21:38 GMT Message-Id: <202312041521.3B4FLc8Q087917@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: 9b2326333e88 - stable/13 - pfctl: use libpfctl instead of DIOCGETRULES directly List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 9b2326333e884bc239d06be7cbd8a4eef571c5eb Auto-Submitted: auto-generated The branch stable/13 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=9b2326333e884bc239d06be7cbd8a4eef571c5eb commit 9b2326333e884bc239d06be7cbd8a4eef571c5eb Author: Kristof Provost AuthorDate: 2023-11-24 23:43:48 +0000 Commit: Kristof Provost CommitDate: 2023-12-04 15:21:05 +0000 pfctl: use libpfctl instead of DIOCGETRULES directly MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 47a0b59379c3bec547e7c829eb12de8276227dff) --- sbin/pfctl/pfctl_optimize.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/sbin/pfctl/pfctl_optimize.c b/sbin/pfctl/pfctl_optimize.c index 8aadccbb2178..00e1cf86e6fe 100644 --- a/sbin/pfctl/pfctl_optimize.c +++ b/sbin/pfctl/pfctl_optimize.c @@ -878,24 +878,23 @@ block_feedback(struct pfctl *pf, struct superblock *block) int load_feedback_profile(struct pfctl *pf, struct superblocks *superblocks) { + char anchor_call[MAXPATHLEN] = ""; struct superblock *block, *blockcur; struct superblocks prof_superblocks; struct pf_opt_rule *por; struct pf_opt_queue queue; - struct pfioc_rule pr; + struct pfctl_rules_info rules; struct pfctl_rule a, b, rule; int nr, mnr; TAILQ_INIT(&queue); TAILQ_INIT(&prof_superblocks); - memset(&pr, 0, sizeof(pr)); - pr.rule.action = PF_PASS; - if (ioctl(pf->dev, DIOCGETRULES, &pr)) { + if (pfctl_get_rules_info(pf->dev, &rules, PF_PASS, "")) { warn("DIOCGETRULES"); return (1); } - mnr = pr.nr; + mnr = rules.nr; DEBUG("Loading %d active rules for a feedback profile", mnr); for (nr = 0; nr < mnr; ++nr) { @@ -904,15 +903,14 @@ load_feedback_profile(struct pfctl *pf, struct superblocks *superblocks) warn("calloc"); return (1); } - pr.nr = nr; - if (pfctl_get_rule(pf->dev, nr, pr.ticket, "", PF_PASS, - &rule, pr.anchor_call)) { + if (pfctl_get_rule(pf->dev, nr, rules.ticket, "", PF_PASS, + &rule, anchor_call)) { warn("DIOCGETRULENV"); return (1); } memcpy(&por->por_rule, &rule, sizeof(por->por_rule)); - rs = pf_find_or_create_ruleset(pr.anchor_call); + rs = pf_find_or_create_ruleset(anchor_call); por->por_rule.anchor = rs->anchor; if (TAILQ_EMPTY(&por->por_rule.rpool.list)) memset(&por->por_rule.rpool, 0,