From owner-soc-status@FreeBSD.ORG Sun Aug 23 12:24:27 2009 Return-Path: Delivered-To: soc-status@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C42531065692; Sun, 23 Aug 2009 12:24:27 +0000 (UTC) (envelope-from upczhsh@gmail.com) Received: from mail-iw0-f174.google.com (mail-iw0-f174.google.com [209.85.223.174]) by mx1.freebsd.org (Postfix) with ESMTP id 7A6478FC18; Sun, 23 Aug 2009 12:24:27 +0000 (UTC) Received: by iwn4 with SMTP id 4so714441iwn.3 for ; Sun, 23 Aug 2009 05:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type; bh=3TnvGTWQRwf8LU4kiG57qlQHoSQikwee+s4XGU1Jfkk=; b=fS/CZGIC/C91PElOOeSB3/EJueeeyLMjUPbMzByDLjIs3ifMiMjigx43ttvZe8RYrY JLtpayPpCBq5TTdph2f9c212GORPl+kP1QnvTQRDszdJY9cCpL7XbaVaruNWktwrLWCD il5XedB9+BhBH+AwCffkfdXsQK+YV40PXHoTY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=p7Prr0lpBYT7FXugHu0P/6xcQt8TYzo9fmAeBJQ2zFwHs8Al3PVl6EEXuizg0/OaIA MjXgQg2zuykHHp784gnrMBF2isKB1L37Gcy42Kd+3B+S71/x7j3diJoAn38NvCVIMgmI 3BKXNcC052fElsm7kAgLq+c3UQP4s/G7WsoGc= MIME-Version: 1.0 Sender: upczhsh@gmail.com Received: by 10.231.32.138 with SMTP id c10mr1651389ibd.28.1251030266899; Sun, 23 Aug 2009 05:24:26 -0700 (PDT) In-Reply-To: <20090822130445.GM1292@hoeg.nl> References: <8126ef5c0908220125u42463afbm3303413015c05107@mail.gmail.com> <20090822130445.GM1292@hoeg.nl> Date: Sun, 23 Aug 2009 20:24:26 +0800 X-Google-Sender-Auth: d913380e8f1a3b7a Message-ID: <8126ef5c0908230524g177f29d2qe836ad66c0c3f016@mail.gmail.com> From: Zhao Shuai To: Ed Schouten , soc-status , John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: FIFO Optimization - final summary X-BeenThere: soc-status@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Summer of Code Status Reports and Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 12:24:27 -0000 2009/8/22 Ed Schouten > Hi, > > * Zhao Shuai wrote: > > Hi All, > > > > This summer I worked on rewriting the FIFO(named pipe) subsystem. > > The new FIFO system uses pipe implementation while previously > > it is implemented as socket. > > > > The new FIFO code passes the official regression test and the following > > bugs has been eliminated: PR 76525,PR 94772,PR 76144,PR 116770. > > According to my performance test, the new FIFO system increases the > > throughput by 30% comparing with the old one. > > > > I will continue to improve my code after GSoC and hope it can be merged > > with the main tree. > > I'm too lazy to read the source, check out sources, etc. but the pipe > and fifo code has now been merged, right? Just out of curiosity, how do these changes affect the kernel binary size? How many lines of code have been added/removed? The original pipe code is moved into sys/kern/subr_pipe.c where we deal with pipe internals. Most of the pipe code is kept untouched except some changes to several function prototype. /sys/kern/sys_pipe.c is now just a wrapper of pipe routines. The affect on the kernel binary size is negligible. -- Regards, Zhao