From owner-cvs-src@FreeBSD.ORG Tue Jul 13 19:51:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7619016A4CE; Tue, 13 Jul 2004 19:51:20 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2BA8543D31; Tue, 13 Jul 2004 19:51:20 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-63-195-111-154.dsl.snfc21.pacbell.net [63.195.111.154]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i6DJpIrb027547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 13 Jul 2004 12:51:19 -0700 Message-ID: <40F43D36.2000407@root.org> Date: Tue, 13 Jul 2004 12:51:18 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <20040713193703.ECB0016A53F@hub.freebsd.org> In-Reply-To: <20040713193703.ECB0016A53F@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/kldunload kldunload.8 kldunload.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2004 19:51:20 -0000 Poul-Henning Kamp wrote: > Give kldunload a -f(orce) argument. > > Add a MOD_QUIESCE event for modules. This should return error (EBUSY) > of the module is in use. > > MOD_UNLOAD should now only fail if it is impossible (as opposed to > inconvenient) to unload the module. Valid reasons are memory references > into the module which cannot be tracked down and eliminated. > > When kldunloading, we abandon if MOD_UNLOAD fails, and if -force is > not given, MOD_QUIESCE failing will also prevent the unload. Hmmm, a quick check of the archives shows that I missed your discussion of this on Thursday/Friday when I was on vacation. (Including the extremely useful naming replies!) Have you kept up on the newbus discussions? The tentative plan was to add quiesce functionality to it as part of device_detach(). Doing it at the module layer is a bit too low since there are events that can trigger a detach but not an unload. For instance, any driver compiled into the kernel for an ejectable device will never be unloaded, but certainly should quiesce/detach when the device is ejected. Getting it right in newbus automatically fixes the problem you're trying to solve since a module unload always triggers a call to device_detach() but not vice versa. I think duplicating this at multiple layers is not a good idea and the module level is not the right layer to implement it. -- -Nate