Date: Sun, 25 Nov 2012 12:46:55 GMT From: Rainer Hurling <rhurlin@gwdg.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/173906: [patch] audio/last.fm: fix build with clang Message-ID: <201211251246.qAPCktF3080358@red.freebsd.org> Resent-Message-ID: <201211251250.qAPCo0sc049657@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173906
>Category: ports
>Synopsis: [patch] audio/last.fm: fix build with clang
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 25 12:50:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Rainer Hurling
>Release: 10.0-CURRENT amd64
>Organization:
>Environment:
FreeBSD xxx.xxx 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r243326: Tue Nov 20 08:55:20 CET 2012 xxx@xxx.xxx:/usr/obj/usr/src/sys/XXX amd64
>Description:
Trying to build audio/last.fm with clang (systems compiler) ends up with this error:
cd src/libFingerprint/fplib/pro_qmake/ && /usr/local/bin/qmake-qt4 /usr/ports/audio/last.fm/work/last.fm-1.4.2.58240/src/libFingerprint/fplib/pro_qmake/fplib.pro -config release -o Makefile.fplib
WARNING: /usr/ports/audio/last.fm/work/last.fm-1.4.2.58240/src/libUnicorn/unicorn.pro.inc:9: Variable LIBPATH is deprecated; use QMAKE_LIBDIR instead.
cd src/libFingerprint/fplib/pro_qmake/ && /usr/bin/make -f Makefile.fplib all
clang++ -c -pipe -O2 -w -fPIC -DNBREAKPAD -DNDEBUG -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I../../../../src -I../../../../build -I../../../libMoose -I../../../libUnicorn -I../include -I../src -I../../libs/fftw/src/api -I../../../../res/libsamplerate -I/usr/local/include/qt4 -I/usr/local/include -o ../../../../build/fplib/release/FingerprintExtractor.o ../src/FingerprintExtractor.cpp
In file included from ../src/FingerprintExtractor.cpp:40:
./src/FloatingAverage.h:81:28: error: reference to non-static member function must be called; did you mean to call it with
no arguments?
for ( int i = 0; i < size; ++i )
^~~~
()
1 error generated.
*** [../../../../build/fplib/release/FingerprintExtractor.o] Error code 1
Stop in /usr/ports/audio/last.fm/work/last.fm-1.4.2.58240/src/libFingerprint/fplib/pro_qmake.
*** [sub-src-libFingerprint-fplib-pro_qmake-fplib-pro-all-ordered] Error code 1
Stop in /usr/ports/audio/last.fm/work/last.fm-1.4.2.58240.
*** [do-build] Error code 1
>How-To-Repeat:
Build audio/last.fm with clang.
>Fix:
It seems the problem is, that 'size' is not declared. I am not sure, if my patch from below is the correct solution, but it works. Please, have a look if declaring
const int size = m_values.size();
is the right way for that, thanks.
Patch attached with submission follows:
--- src/libFingerprint/fplib/src/FloatingAverage.h.orig 2007-12-18 15:18:19.000000000 +0100
+++ src/libFingerprint/fplib/src/FloatingAverage.h 2012-11-25 13:23:10.000000000 +0100
@@ -78,6 +78,7 @@
{
T real_sum = 0;
const T* pCircularBuffer = m_values.get_buffer();
+ const int size = m_values.size();
for ( int i = 0; i < size; ++i )
real_sum += pCircularBuffer[i];
return abs(real_sum - m_sum) / this->size();
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211251246.qAPCktF3080358>