From owner-cvs-all Mon Jul 8 5:16:10 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2538837B400; Mon, 8 Jul 2002 05:16:04 -0700 (PDT) Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22EEC43E31; Mon, 8 Jul 2002 05:16:02 -0700 (PDT) (envelope-from sheldonh@starjuice.net) Received: from sheldonh by axl.seasidesoftware.co.za with local (Exim 3.36 #1) id 17RXS6-000KcJ-00; Mon, 08 Jul 2002 14:17:14 +0200 Date: Mon, 8 Jul 2002 14:17:14 +0200 From: Sheldon Hearn To: Juli Mallett Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps print.c Message-ID: <20020708121714.GF75407@starjuice.net> Mail-Followup-To: Juli Mallett , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200207072146.g67Lk0nT041098@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200207072146.g67Lk0nT041098@freefall.freebsd.org> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On (2002/07/07 14:45), Juli Mallett wrote: > Modified files: > bin/ps print.c > Log: > Make printval() take a 'void *' thus negating any assumptions the compiler > may try to make about the alignment of the dereferenced datum. Doesn't this break buildworld with warnings promoted to errors? ===> bin/ps [...] cc -O -pipe -march=pentiumpro -DLAZY_PS -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wformat=2 -Wno-format-extra-args -Werror -c /usr/src/bin/ps/print.c cc1: warnings being treated as errors /usr/src/bin/ps/print.c: In function `started': /usr/src/bin/ps/print.c:400: warning: `%y' yields only last 2 digits of year /usr/src/bin/ps/print.c: In function `lstarted': /usr/src/bin/ps/print.c:417: warning: `%c' yields only last 2 digits of year in some locales on non-BSD systems /usr/src/bin/ps/print.c: In function `printval': /usr/src/bin/ps/print.c:686: warning: format not a string literal, argument types not checked /usr/src/bin/ps/print.c:689: warning: format not a string literal, argument types not checked [...] Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message