From owner-freebsd-current Fri Jul 2 17:30:32 1999 Delivered-To: freebsd-current@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id 91C7415199 for ; Fri, 2 Jul 1999 17:30:19 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id KAA14557; Sat, 3 Jul 1999 10:00:18 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id KAA02130; Sat, 3 Jul 1999 10:00:17 +0930 (CST) Date: Sat, 3 Jul 1999 10:00:17 +0930 From: Greg Lehey To: Ben Rosengart Cc: "Brian F. Feldman" , current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <19990703100017.A87392@freebie.lemis.com> References: <19990703093223.V87392@freebie.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: ; from Ben Rosengart on Sat, Jul 03, 1999 at 12:09:53AM +0000 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Saturday, 3 July 1999 at 0:09:53 +0000, Ben Rosengart wrote: > On Sat, 3 Jul 1999, Greg Lehey wrote: > >> I personally think that, in such a case, you'd be justified to commit >> it as a temporary measure. Due to the difference in time zones, this >> has hit people while I've been asleep. That doesn't mean the commit >> would stay, of course, but at least it would save people unnecessary >> pain. Note, of course, that I have now committed the correct file, >> which I had forgotten last night. >> >> What do you others think? > > Was the fix that wasn't yours correct? No. > 'Cause I'd rather have code that doesn't compile than code that > compiles but is subtly wrong. Well, you can now have code that compiles and is correct :-) Seriously, the only problem with Brian's fix was that it added a new variable. It would have made the stats list functions not work. I think that, for the period of time it would have been there, it would have been the right thing to do: most people don't use Vinum, so the breakage there is just a thorn in their side. For those who do, they'll notice the problem and report it. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message