From owner-svn-src-head@FreeBSD.ORG Tue May 19 18:58:59 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54800106566B; Tue, 19 May 2009 18:58:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 264F78FC0A; Tue, 19 May 2009 18:58:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id BA29A46B1A; Tue, 19 May 2009 14:58:58 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 9E6118A025; Tue, 19 May 2009 14:58:57 -0400 (EDT) From: John Baldwin To: Julian Elischer Date: Tue, 19 May 2009 13:30:53 -0400 User-Agent: KMail/1.9.7 References: <200905182234.n4IMYifY077079@svn.freebsd.org> <200905190819.12407.jhb@freebsd.org> <4A12E85B.7050107@elischer.org> In-Reply-To: <4A12E85B.7050107@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905191330.54024.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 19 May 2009 14:58:57 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org Subject: Re: svn commit: r192351 - head/sys/netinet X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2009 18:58:59 -0000 On Tuesday 19 May 2009 1:11:55 pm Julian Elischer wrote: > John Baldwin wrote: > > On Monday 18 May 2009 6:34:44 pm Bjoern A. Zeeb wrote: > >> Author: bz > >> Date: Mon May 18 22:34:44 2009 > >> New Revision: 192351 > >> URL: http://svn.freebsd.org/changeset/base/192351 > >> > >> Log: > >> Revert the logical change of r192341. > >> > >> net.inet.ip.fw.one_pass is a classic ip_input.c variable and is used in > >> the pfil and bridge code as well. As ipfw is loadable we need to always > >> provide it. That is the reason why it lives in struct vnet_inet and > >> not in struct vnet_ipfw. > > > > Gah, I had thought I had seen it in vnet_ipfw when adding default_to_accept > > (as at first I had looked into making default_to_accept per-image but > > tunables + VIMAGE don't mix). > > we need to look at this.. what does it MEAN to have a tunable and > multiple images? my guess is that normal tunables are only valid for > teh base image, but that one might have a way to set the 'tunables' > for one's child images.. possibly by setting them in one's environment? Do you have a kernel environment per vimage? If not, you could still have per-vimage variables that are settable via tunables look at kenv during vimage creation to parse any tunables perhaps. However, that is possibly tricky since you can sometimes use sysctl.conf to override a setting done via loader.conf and in that case, what value should a new vimage get? -- John Baldwin