From owner-freebsd-rc@FreeBSD.ORG  Mon Jul 14 20:44:17 2014
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2A6E0FDB;
 Mon, 14 Jul 2014 20:44:17 +0000 (UTC)
Received: from shxd.cx (unknown [64.201.244.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1484121D3;
 Mon, 14 Jul 2014 20:44:17 +0000 (UTC)
Received: from 50-196-156-133-static.hfc.comcastbusiness.net
 ([50.196.156.133]:51343 helo=THEMADHATTER)
 by shxd.cx with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77 (FreeBSD))
 (envelope-from <devin@shxd.cx>)
 id 1X6axa-000DW5-Cr; Mon, 14 Jul 2014 00:46:06 -0700
From: <dteske@FreeBSD.org>
To: <freebsd-rc@freebsd.org>
Subject: Bug 191869 - tmux(1) refuses to start via service(8)
Date: Mon, 14 Jul 2014 13:43:58 -0700
Message-ID: <017a01cf9fa4$568196e0$0384c4a0$@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="----=_NextPart_000_017B_01CF9F69.AA22E5F0"
X-Mailer: Microsoft Outlook 15.0
Thread-Index: Ac+fossl4HxLjTgkRkyecqGUheos2w==
Content-Language: en-us
Sender: devin@shxd.cx
Cc: dteske@freebsd.org, Allan Jude <allanjude@freebsd.org>,
 'Michael Dexter' <editor@callfortesting.org>
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc/>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jul 2014 20:44:17 -0000

This is a multipart message in MIME format.

------=_NextPart_000_017B_01CF9F69.AA22E5F0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi -rc,

I'd like to get a review on a proposed patch to service(8).

I've filed BUG #191869:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191869

Proposed commit/message below:

Fix an issue with service(8) where utilities such as screen(1) and tmux(1)
would behave differently when utilizing rc-script was invoked manually vs.
service(8). The issue being that these utilities require the TERM environ
variable to be set and service(8) was not passing it down.

Reported by:	Michael Dexter <editor@callfortesting.org>
Reviewed by:	<your name here>
MFC after:	3 days
X-MFC-to:	stable/10, stable/9
--This line, and those below, will be ignored--

M    service/service.sh

<see attached patch.txt>

------=_NextPart_000_017B_01CF9F69.AA22E5F0
Content-Type: text/plain;
	name="patch.txt"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="patch.txt"

Index: usr.sbin/service/service.sh=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
--- usr.sbin/service/service.sh	(revision 268628)=0A=
+++ usr.sbin/service/service.sh	(working copy)=0A=
@@ -139,7 +139,7 @@ cd /=0A=
 for dir in /etc/rc.d $local_startup; do=0A=
 	if [ -x "$dir/$script" ]; then=0A=
 		[ -n "$VERBOSE" ] && echo "$script is located in $dir"=0A=
-		exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin =
$dir/$script $*=0A=
+		exec env -i HOME=3D/ PATH=3D/sbin:/bin:/usr/sbin:/usr/bin =
TERM=3D"$TERM" $dir/$script $*=0A=
 	fi=0A=
 done=0A=
 =0A=

------=_NextPart_000_017B_01CF9F69.AA22E5F0--