From owner-svn-src-all@FreeBSD.ORG Tue Apr 12 22:41:53 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 463301065672; Tue, 12 Apr 2011 22:41:53 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3697B8FC16; Tue, 12 Apr 2011 22:41:53 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p3CMfr78037770; Tue, 12 Apr 2011 22:41:53 GMT (envelope-from jkim@svn.freebsd.org) Received: (from jkim@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p3CMfrhY037768; Tue, 12 Apr 2011 22:41:53 GMT (envelope-from jkim@svn.freebsd.org) Message-Id: <201104122241.p3CMfrhY037768@svn.freebsd.org> From: Jung-uk Kim Date: Tue, 12 Apr 2011 22:41:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220581 - head/sys/x86/isa X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2011 22:41:53 -0000 Author: jkim Date: Tue Apr 12 22:41:52 2011 New Revision: 220581 URL: http://svn.freebsd.org/changeset/base/220581 Log: Do not use TSC for DELAY(9) if it not P-state invariant to avoid possible foot-shooting. DELAY() becomes unreliable when TSC frequency varies wildly, especially cpufreq(4) and powerd(8) are used at the same time. Modified: head/sys/x86/isa/clock.c Modified: head/sys/x86/isa/clock.c ============================================================================== --- head/sys/x86/isa/clock.c Tue Apr 12 22:22:01 2011 (r220580) +++ head/sys/x86/isa/clock.c Tue Apr 12 22:41:52 2011 (r220581) @@ -263,7 +263,7 @@ delay_tc(int n) tc = timecounter; freq = atomic_load_acq_64(&tsc_freq); - if (freq != 0) { + if (tsc_is_invariant && freq != 0) { func = get_tsc; mask = ~0u; } else {