From owner-svn-src-head@FreeBSD.ORG Mon Jan 12 14:55:19 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 12D60F89; Mon, 12 Jan 2015 14:55:19 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8ED0486D; Mon, 12 Jan 2015 14:55:17 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t0CEtFiN020132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 12 Jan 2015 17:55:15 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t0CEtF67020131; Mon, 12 Jan 2015 17:55:15 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 12 Jan 2015 17:55:15 +0300 From: Gleb Smirnoff To: "Alexander V. Chernikov" Subject: Re: svn commit: r276844 - head/sys/netinet6 Message-ID: <20150112145515.GN15484@FreeBSD.org> References: <201501081802.t08I26nA010368@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201501081802.t08I26nA010368@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2015 14:55:19 -0000 On Thu, Jan 08, 2015 at 06:02:06PM +0000, Alexander V. Chernikov wrote: A> Author: melifaro A> Date: Thu Jan 8 18:02:05 2015 A> New Revision: 276844 A> URL: https://svnweb.freebsd.org/changeset/base/276844 A> A> Log: A> * Use newly-created nd6_grab_holdchain() function to retrieve lle A> hold mbuf chain instead of calling full-blown nd6_output_lle() A> for each packet. This simplifies both callers and nd6_output_lle() A> implementation. A> * Make nd6_output_lle() static and remove now-unused lle and chain A> arguments. A> * Rename nd6_output_flush() -> nd6_flush_holdchain() to be consistent. A> * Move all pre-send transmit hooks to newly-created nd6_output_ifp(). A> Now nd6_output(), nd6_output_lle() and nd6_flush_holdchain() are using A> it to send mbufs to if_output. A> * Remove SeND hook from nd6_na_input() because it was implemented A> incorrectly since the beginning (r211501): A> - it tagged initial input mbuf (m) instead of m_hold A> - tagging _all_ mbufs in holdchain seems to be wrong anyway. Thanks that you gathered into one place all instances of ifp->if_output(origifp, ... ^^^ ^^^^^^^ But this extremely ugly place still needs to be fixed :) -- Totus tuus, Glebius.