From owner-cvs-all@FreeBSD.ORG  Mon Dec 20 07:31:18 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 87BAC16A4CE; Mon, 20 Dec 2004 07:31:18 +0000 (GMT)
Received: from lakermmtao02.cox.net (lakermmtao02.cox.net [68.230.240.37])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BB9CD43D3F; Mon, 20 Dec 2004 07:31:17 +0000 (GMT)
	(envelope-from mezz7@cox.net)
Received: from mezz.mezzweb.com ([68.103.32.140]) by lakermmtao02.cox.net
          (InterMail vM.6.01.04.00 201-2131-117-20041022) with ESMTP
          id <20041220073114.FBQP2202.lakermmtao02.cox.net@mezz.mezzweb.com>;
          Mon, 20 Dec 2004 02:31:14 -0500
Date: Mon, 20 Dec 2004 01:32:09 -0600
To: "Alexey Dokuchaev" <danfe@freebsd.org>
References: <200412200709.iBK79Q2n015446@repoman.freebsd.org>
From: "Jeremy Messenger" <mezz7@cox.net>
Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID: <opsjapvver9aq2h7@mezz.mezzweb.com>
In-Reply-To: <200412200709.iBK79Q2n015446@repoman.freebsd.org>
User-Agent: Opera M2/7.54u1 (Linux, build 892)
cc: cvs-ports@freebsd.org
cc: cvs-all@freebsd.org
cc: ports-committers@freebsd.org
Subject: Re: cvs commit: ports/x11-themes/gtk-aluminumalloy-cryogenic-theme
	pkg-plist ports/x11-themes/gtk-aluminumalloy-smog-theme
	pkg-plist ports/x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist
	ports/x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Dec 2004 07:31:18 -0000

On Mon, 20 Dec 2004 07:09:26 +0000 (UTC), Alexey Dokuchaev  
<danfe@FreeBSD.org> wrote:

> danfe       2004-12-20 07:09:25 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     x11-themes/gtk-aluminumalloy-cryogenic-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-smog-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist
>   Log:
>   Remove directory that might be empty.

Why not depend on gtk and metacity? You can't use those theme without gtk  
and metacity. If you depend on those and you won't have that pkg-plist  
problem. Suggest to change like this:

==========================================
.if ${TYPE} == "gtk"
+USE_GNOME=gtk20
THEME_DIR=${PREFIX}/share/themes/${THEME_NAME}
PLIST_SUB+=GTK20=""
PLIST_SUB+=METACITY="@comment "
.else# metacity
+USE_GNOME=metacity
THEME_DIR=${PREFIX}/share/gnome/themes/${THEME_NAME}
PLIST_SUB+=GTK20="@comment "
PLIST_SUB+=METACITY=""
.endif
==========================================

But, what if a user want to have both gtk and metacity?

Cheers,
Mezz

>   Noticed by:     kris


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org