From owner-freebsd-security@freebsd.org Tue Aug 21 08:12:07 2018 Return-Path: Delivered-To: freebsd-security@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74141108D1A0 for ; Tue, 21 Aug 2018 08:12:07 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E803D7859E for ; Tue, 21 Aug 2018 08:12:06 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w7L8BoNA032452 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Aug 2018 11:11:53 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w7L8BoNA032452 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w7L8BoeM032451; Tue, 21 Aug 2018 11:11:50 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Tue, 21 Aug 2018 11:11:50 +0300 From: Konstantin Belousov To: bowwave Cc: freebsd-security@freebsd.org Subject: Re: Corruption seen from OCF after applying FreeBSD-SA-18:07.lazyfpu. Message-ID: <20180821081150.GU2340@kib.kiev.ua> References: <250A8BA1-0E7E-4CF9-875B-A41ABADE86CB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <250A8BA1-0E7E-4CF9-875B-A41ABADE86CB@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-Mailman-Approved-At: Tue, 21 Aug 2018 10:54:34 +0000 X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 08:12:07 -0000 On Mon, Aug 20, 2018 at 08:07:04PM -0700, bowwave wrote: > > We have a product that uses OCF to encrypt disk blocks. Since > applying the FreeBSD-SA-18:07.lazyfpu patch we are seeing occasional > corruption. The amount of corrupted data is always less than the > request size and is always a multiple of the AES block size. Retrying > the operation always succeeds leading to the conclusion that this > seems to be a locking issue. The only thing so far that we can come > up with is that this seems to result from either the OCF layer itself > or the AES-NI driver below it. Looking for suggestions about where to > proceed next. > Most likely you need r336683, merged as r336963 to stable/11 and r337245 to stable/10. Some day there will be an EN.