Date: Mon, 09 Sep 2019 16:18:44 +0000 From: bugzilla-noreply@freebsd.org To: perl@FreeBSD.org Subject: maintainer-feedback requested: [Bug 240450] x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes Message-ID: <bug-240450-14331-wtlHm69g59@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240450-14331@https.bugs.freebsd.org/bugzilla/> References: <bug-240450-14331@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-perl mailing l= ist <perl@FreeBSD.org> for maintainer-feedback: Bug 240450: x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240450 --- Description --- post-patch phase of this port uses sed to replace 'wx-config with '${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in = this context. Remove the extraneous escape so that it doesn't get passed through to sed(1= ) as an escape of an ordinary character. This is important as the patch in bug #229925 will make such escapes an error to ease transition into a world whe= re some escaped-ordinaries will be granted a special meaning. This patch also contains a pkg-plist update to include Config/gtk_3* -- I do not know if this is correct, but it was needed to get through a poudriere testport so I've included it. QA: * portlint: OK (minor warnings that should be addressed separately.) * testport: OK (poudriere: 12.0-RELEASE, amd64[*]) [*] Only minimal testing done because the nature of the patch would lead to arch-independent catastrophic meltdown
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240450-14331-wtlHm69g59>