Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Sep 2020 11:38:45 +0000 (UTC)
From:      =?UTF-8?Q?Stefan_E=c3=9fer?= <se@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r547532 - head/sysutils/lttng-ust/files
Message-ID:  <202009041138.084Bcjoe048304@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: se
Date: Fri Sep  4 11:38:45 2020
New Revision: 547532
URL: https://svnweb.freebsd.org/changeset/ports/547532

Log:
  Fix build with -fno-common
  
  While this makes the build process proceed past the point where the it
  previously failed with -fno-common, it still fails later in the examples.
  
  There is a comment in a README file that mentions BUILD_EXAMPLES_FROM_TREE,
  but I could not find any actual reference to that parameter outside the
  README file and the build failed with and without it set.
  
  This commit is meant to document the changes require due to -no-common
  and I leave the fix required in lttng-ust-2.9.0/doc/examples/gen-tp for
  a later time or another committer.
  
  The PORTREVISION is not bumped, since the build still fails for me.

Added:
  head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c   (contents, props changed)
Modified:
  head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c

Modified: head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c
==============================================================================
--- head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c	Fri Sep  4 11:30:40 2020	(r547531)
+++ head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c	Fri Sep  4 11:38:45 2020	(r547532)
@@ -20,3 +20,12 @@
  
  #include <usterr-signal-safe.h>
  #include <ust-comm.h>
+@@ -76,7 +88,7 @@ extern void lttng_ring_buffer_client_discard_exit(void
+ extern void lttng_ring_buffer_client_discard_rt_exit(void);
+ extern void lttng_ring_buffer_metadata_client_exit(void);
+ 
+-volatile enum ust_loglevel ust_loglevel;
++extern volatile enum ust_loglevel ust_loglevel;
+ 
+ int ustctl_release_handle(int sock, int handle)
+ {

Added: head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c	Fri Sep  4 11:38:45 2020	(r547532)
@@ -0,0 +1,11 @@
+--- liblttng-ust-fd/lttng-ust-fd.c.orig	2016-11-29 01:46:24 UTC
++++ liblttng-ust-fd/lttng-ust-fd.c
+@@ -28,7 +28,7 @@
+ #include <helper.h>
+ #include "usterr-signal-safe.h"
+ 
+-volatile enum ust_loglevel ust_loglevel;
++extern volatile enum ust_loglevel ust_loglevel;
+ 
+ static int (*__lttng_ust_fd_plibc_close)(int fd);
+ 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202009041138.084Bcjoe048304>