From owner-svn-ports-all@freebsd.org Fri Sep 4 11:38:45 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E90623DDFDD; Fri, 4 Sep 2020 11:38:45 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BjbKd5sPTz3dG0; Fri, 4 Sep 2020 11:38:45 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AC7B0C093; Fri, 4 Sep 2020 11:38:45 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 084Bcjnd048306; Fri, 4 Sep 2020 11:38:45 GMT (envelope-from se@FreeBSD.org) Received: (from se@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 084Bcjoe048304; Fri, 4 Sep 2020 11:38:45 GMT (envelope-from se@FreeBSD.org) Message-Id: <202009041138.084Bcjoe048304@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: se set sender to se@FreeBSD.org using -f From: =?UTF-8?Q?Stefan_E=c3=9fer?= Date: Fri, 4 Sep 2020 11:38:45 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r547532 - head/sysutils/lttng-ust/files X-SVN-Group: ports-head X-SVN-Commit-Author: se X-SVN-Commit-Paths: head/sysutils/lttng-ust/files X-SVN-Commit-Revision: 547532 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 11:38:46 -0000 Author: se Date: Fri Sep 4 11:38:45 2020 New Revision: 547532 URL: https://svnweb.freebsd.org/changeset/ports/547532 Log: Fix build with -fno-common While this makes the build process proceed past the point where the it previously failed with -fno-common, it still fails later in the examples. There is a comment in a README file that mentions BUILD_EXAMPLES_FROM_TREE, but I could not find any actual reference to that parameter outside the README file and the build failed with and without it set. This commit is meant to document the changes require due to -no-common and I leave the fix required in lttng-ust-2.9.0/doc/examples/gen-tp for a later time or another committer. The PORTREVISION is not bumped, since the build still fails for me. Added: head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c (contents, props changed) Modified: head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c Modified: head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c ============================================================================== --- head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c Fri Sep 4 11:30:40 2020 (r547531) +++ head/sysutils/lttng-ust/files/patch-liblttng-ust-ctl_ustctl.c Fri Sep 4 11:38:45 2020 (r547532) @@ -20,3 +20,12 @@ #include #include +@@ -76,7 +88,7 @@ extern void lttng_ring_buffer_client_discard_exit(void + extern void lttng_ring_buffer_client_discard_rt_exit(void); + extern void lttng_ring_buffer_metadata_client_exit(void); + +-volatile enum ust_loglevel ust_loglevel; ++extern volatile enum ust_loglevel ust_loglevel; + + int ustctl_release_handle(int sock, int handle) + { Added: head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sysutils/lttng-ust/files/patch-liblttng-ust-fd_lttng-ust-fd.c Fri Sep 4 11:38:45 2020 (r547532) @@ -0,0 +1,11 @@ +--- liblttng-ust-fd/lttng-ust-fd.c.orig 2016-11-29 01:46:24 UTC ++++ liblttng-ust-fd/lttng-ust-fd.c +@@ -28,7 +28,7 @@ + #include + #include "usterr-signal-safe.h" + +-volatile enum ust_loglevel ust_loglevel; ++extern volatile enum ust_loglevel ust_loglevel; + + static int (*__lttng_ust_fd_plibc_close)(int fd); +