From owner-freebsd-current@FreeBSD.ORG  Wed Oct  8 01:04:21 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DBEAA16A4B3
	for <current@FreeBSD.ORG>; Wed,  8 Oct 2003 01:04:21 -0700 (PDT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E361543FDD
	for <current@FreeBSD.ORG>; Wed,  8 Oct 2003 01:04:17 -0700 (PDT)
	(envelope-from sos@spider.deepcore.dk)
Received: from spider.deepcore.dk (localhost [127.0.0.1])
	by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id h98841be032174;
	Wed, 8 Oct 2003 10:04:01 +0200 (CEST)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.10/8.12.10/Submit) id h98841NN032169;
	Wed, 8 Oct 2003 10:04:01 +0200 (CEST)
	(envelope-from sos)
From: Soren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200310080804.h98841NN032169@spider.deepcore.dk>
In-Reply-To: <1065598633.868.2.camel@localhost>
To: "Vladimir B. Grebenschikov" <vova@fbsd.ru>
Date: Wed, 8 Oct 2003 10:04:01 +0200 (CEST)
X-Mailer: ELM [version 2.4ME+ PL99f (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
X-mail-scanned: by DeepCore Virus & Spam killer v1.3
cc: "current@freebsd.org" <current@FreeBSD.ORG>
Subject: Re: ATAng doesn't boot on my notebook - panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Oct 2003 08:04:22 -0000

It seems Vladimir B. Grebenschikov wrote:
> Does not help, another panic in ad_attach:
 
ARGH, try this instead:

diff -u -r1.191 ata-all.c
--- ata-all.c   7 Oct 2003 13:44:15 -0000       1.191
+++ ata-all.c   8 Oct 2003 08:03:09 -0000
@@ -35,6 +35,7 @@
 #include <sys/ata.h>
 #include <sys/kernel.h>
 #include <sys/endian.h>
+#include <sys/ctype.h>
 #include <sys/conf.h>
 #include <sys/bus.h>
 #include <sys/bio.h>
@@ -555,6 +556,8 @@
            }
            ata_free_request(request);
        }
+       if (!isalpha(atacap->model[0]) || !isalpha(atacap->model[1]))
+           error = ENXIO;
        if (error) {
            atadev->param = NULL;
            free(atacap, M_ATA);


-Søren