Date: Thu, 7 Nov 2019 19:45:30 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r516900 - in head/multimedia: ffms2 vapoursynth vapoursynth-l-smash-works Message-ID: <20191107184530.qhh5xrchgjhmxs3a@atuin.in.mat.cc> In-Reply-To: <tv7f-1xih-wny@FreeBSD.org> References: <201911061642.xA6GgS3V041740@repo.freebsd.org> <20191107081032.kqotphm5wzk3bhgf@atuin.in.mat.cc> <zhh7-gbfu-wny@FreeBSD.org> <20191107140053.d36yftvnvxceyhps@ogg.in.absolight.net> <tv7f-1xih-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nzrs6offcduc35jh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 07, 2019 at 05:06:46PM +0100, Jan Beich wrote: > Mathieu Arnold <mat@FreeBSD.org> writes: >=20 > > On Thu, Nov 07, 2019 at 12:42:13PM +0100, Jan Beich wrote: > > > >> Mathieu Arnold <mat@FreeBSD.org> writes: > >>=20 > >> > On Wed, Nov 06, 2019 at 04:42:28PM +0000, Jan Beich wrote: > >> > > >> >> Author: jbeich > >> >> Date: Wed Nov 6 16:42:28 2019 > >> >> New Revision: 516900 > >> >> URL: https://svnweb.freebsd.org/changeset/ports/516900 > >> >>=20 > >> >> Log: > >> >> multimedia/vapoursynth: mark BROKEN on non-x86 > >> >>=20 > >> >> Modified: > >> >> head/multimedia/ffms2/Makefile (contents, props changed) > >> >> head/multimedia/vapoursynth-l-smash-works/Makefile (contents, p= rops changed) > >> >> head/multimedia/vapoursynth/Makefile (contents, props changed) > >> >>=20 > >> >> Modified: head/multimedia/ffms2/Makefile > >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > >> >> --- head/multimedia/ffms2/Makefile Wed Nov 6 16:42:19 2019 (r51689= 9) > >> >> +++ head/multimedia/ffms2/Makefile Wed Nov 6 16:42:28 2019 (r51690= 0) > >> >> @@ -11,18 +11,24 @@ COMMENT=3D FFmpeg-based source library and Vapo= urSynth p > >> >> LICENSE=3D MIT > >> >> LICENSE_FILE=3D ${WRKSRC}/COPYING > >> >> =20 > >> >> +.if ${MACHINE_ARCH} =3D=3D amd64 || ${MACHINE_ARCH} =3D=3D i386 > >> > > >> > We never use MACHINE_ARCH in the ports tree, we use ARCH, and it is = only > >> > available after an include. All our tools use/set ARCH, so, please = use > >> > it. > >>=20 > >> This is a temporary workaround, so avoiding "svn blame" churn is prefe= rred. > >> Also, I planned to switch ARCH to use MACHINE_ARCH internally in bug 2= 15401. > > > > Whatever the reason, MACHINE_ARCH must never be used for tests, please > > fix it to use ARCH.=20 >=20 > Can you provide a non-cargo-cult rationale? A number of ports (ignoring > those in question) already use MACHINE_ARCH. I just had a look, there are, right now, 10 ports that go against our policy of NEVER USING MACHINE_ARCH FOR TESTS. So, while 10 is a number, it is not a rule, it is an exception, something that was missed upon review. The rationale is that it is our policy, and as much as I dislike portlint, it has been sayinc so correctly for the past 15 years. You do not use MACHINE_ARCH directly, you use ARCH. --=20 Mathieu Arnold --nzrs6offcduc35jh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl3EZklfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgSNA//ccWnh2w35pupA1p1COA4GT9y4uIMaueZOy7vGElHkLNmlF/xnZ/CVnV7 eNBANeB4G4IG06diqbVuG3A4s5wbQCM+MFP3NOXQIuggU6M82uTY7UtUlu21oGsz nAJ6VheCAWVR2vHyp3fFZwj4BvThmqEKv/97DGU0CaSjeyik/ApKEKE6+nRLx0xO NSuxtjvcDgDb14O1gxLO+POiDPIRGFcEH3blGYb04Bye+rFUNwPxwUpbsu9goA+/ 8Rp8p941vZ2g218Xz5c3F/nWXMKckygk3vXeAglIox8EmfKw3ZGJoOFnxdOfXXuR mQ0RquDJ/y4EnrP+NQJwI13w0Ktek8438dvo71MOvvXaBRi0MkOhY0pINaJ7EaYj fPbevpWGjpeTssAW9Ay26tdmRX3bCnvvmuDGTgEl3cpp/dFAIXtX8snFvOrPhhWH fh2SRXN2CGX7iYMVFWYKwvawdhCxWEtzqtwPASXscgjW44SqJLXA9L1asz4cO8mK b8ceSrmziVTgvnXRD8AIRzRfbA6Tqno24ssHkqMBKur4rc+yz3mqVjHB2kAeSzwt iWHziUI3gjNyFQUVq+ynNHFSEXFr2GDoNcVZ4UxBW9/0AUSEi+Xr0qvHtrHkEmCX dDbNQSt2a/d16KLeH935ybMDmmC4ExejUQa7U6fO0lWbIij4yUs= =he4i -----END PGP SIGNATURE----- --nzrs6offcduc35jh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191107184530.qhh5xrchgjhmxs3a>